feat: ship full and Asset Store addon variants - #239
Merged
Merged
Conversation
Remove Windows ARM64 from CI, bundling, packaging, and the Godot extension manifest. Preserve Windows x64, Linux x64/ARM64, and macOS universal support. BREAKING CHANGE: Native Windows ARM64 builds and exports are no longer supported. This removal may require a major release. Related to #238.
Limit official CI and addon packages to Windows x64, Linux x64, and macOS universal. Preserve Windows and Linux ARM64 source bundling and document manual addon registration in both languages. BREAKING CHANGE: Official Windows ARM64 and Linux ARM64 builds, binary distributions, and Godot export registrations are removed. Unsupported self-build paths remain available. Related to #238.
Contributor
|
@dsh0416 just my opinion: |
Owner
Author
makes sense, I would try to build two different gdextensions, one with all supported archs, and a smaller version to fit Godot assets store. Thank you for mentioning. |
Contributor
|
@dsh0416 thanks |
Preserve Windows and Linux ARM64 in full releases. Add an explicit Store variant with matching filtered GDExtension manifest, strict variant validation, separate staged archives, and both release assets. Follow PR #239 discussion with lublak and dsh0416. Keep the full package as the default and document package choice and source builds in English and Chinese.
dsh0416
marked this pull request as ready for review
September 30, 2026 16:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The full addon approaches the Godot Asset Store size limit, but ARM64 users still need prebuilt release binaries. Produce two addon packages from the same complete platform builds: the existing full GitHub Release package, and a smaller Asset Store package that omits Windows/Linux ARM64. Windows/Linux ARM64 support and binaries remain available in the full package; macOS universal retains both architectures in both packages.
cargo xtask packcontinues to default to the full package.--variant storeselects the three Store targets and generates a matching GDExtension descriptor by removing Windows/Linux ARM64 library and dependency entries from the full source manifest. Both archives keep the existingdist/addons/godot_cef/layout and install as the same addon; users choose one and replace the addon directory when switching.Related Issues
Related to #238. Implements the agreed requirement in lublak's request to retain release binaries and dsh0416's owner response proposing full and smaller Store variants. No review or inline review comments existed when these requirements were read.
Changes Made
pack --variant full|storewith backward-compatiblefulldefault. Full has five platform directories; Store has Windows x64, Linux x64, and macOS universal.validate --variant full|storechecks requiring every selected target, rejecting excluded target directories, and checking manifest target selection. Validation without the option retains partial-addon behavior.godot_cef-addonandgodot_cef-store-addon.godot_cef-v<version>.zipandgodot_cef-store-v<version>.zipto its draft release. This PR does not publish a release or merge anything.The full package retains existing platform coverage and filenames. The optional Store package cannot serve native Windows/Linux ARM64 Godot editor/exports; those users choose the full package. Final ZIP sizes and the exact Asset Store byte limit still require measurement/confirmation. No global ARM64 support removal or major-version bump is proposed by the final implementation.
Testing Performed
On exact head
bbc330a2ad648122f15ed2e12f955c11e42d0f1e:cargo test -p xtask --offline: 7 pre-existing tests passed on macOS ARM64.cargo clippy -p xtask --offline -- -D warnings: passed.cargo fmt --all -- --check,cargo xtask validate-versions,git diff --check: passed.vitepress build docs: passed, including both distribution guide pages and navigation.bash -n.main: restored unchanged.The supplementary packaging regression/temporary fixtures remain removed; no replacement tests were added. Local unit tests emit a pre-existing macOS dead-code warning for runtime asset fields; production Clippy passed. Local verification did not build every CEF target, run ARM64 editor/rendering/export scenarios, or measure complete ZIP sizes. Real full/Store packaging and strict manifest/target validation run in final-head CI.
Final-head CI is pending. Keep draft until applicable checks pass; ready-for-review conversion is handled by the coordinating task. Release publication and documentation deployment are expected to be skipped for PR runs.
Checklist