Skip to content

Specify units and add fields#83

Open
nass13m wants to merge 1 commit into
dschwoerer:develfrom
nass13m:devel
Open

Specify units and add fields#83
nass13m wants to merge 1 commit into
dschwoerer:develfrom
nass13m:devel

Conversation

@nass13m
Copy link
Copy Markdown
Contributor

@nass13m nass13m commented Apr 27, 2023

No description provided.

@dschwoerer
Copy link
Copy Markdown
Owner

@nass13m do you think this is still useful?

Copy link
Copy Markdown
Owner

@dschwoerer dschwoerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in getting back to you!

Comment thread xemc3/data/default.yaml
Comment on lines -69 to +72
TH:
TH2:
units: eV
long_name: Atomic hydrogen temperature
long_name: D_2 temperature
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name: TEMPERATURE_M

Structure: * For each molecule species known by EIRENE: * Molecule temperature in eV (list of floats, length: maximum cell number for neutrals)

Comment thread xemc3/data/default.yaml
DENSITY_E_M_%d: {}
DENSITY_E_M_%d:
scale: 1000000.0
units: m$^{-3}$
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
units: m$^{-3}$
units: "eV m$^{-3}$"

Comment thread xemc3/data/default.yaml
DENSITY_E_I_%d: {}
DENSITY_E_I_%d:
scale: 1000000.0
units: eV.m$^{-3}$
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
units: eV.m$^{-3}$
units: "eV m$^{-3}$"

Comment thread xemc3/data/default.yaml
DENSITY_E_A_%d: {}
DENSITY_E_A_%d:
scale: 1000000.0
units: eV.m$^{-3}$
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
units: eV.m$^{-3}$
units: "eV m$^{-3}$"

Comment thread xemc3/data/default.yaml
type: mapped
vars:
fort.40_%d: {}
SOURCE_P_%d:
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sn%d if this essentially a density source.

Comment thread xemc3/data/default.yaml
type: mapped
vars:
fort.42_%d: {}
SOURCE_E_E:
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if this is the energy density source for electrons

Comment thread xemc3/data/default.yaml
vars:
fort.42_%d: {}
SOURCE_E_E:
units: W.m$^{-3}$
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
units: W.m$^{-3}$
units: "W m$^{-3}$"

or

Suggested change
units: W.m$^{-3}$
units: "eV m$^{-3}$"

?

Comment thread xemc3/data/default.yaml
vars:
fort.43_%d: {}
SOURCE_E_I:
units: W.m$^{-3}$
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
units: W.m$^{-3}$
units: "W m$^{-3}$"

or

Suggested change
units: W.m$^{-3}$
units: "eV m$^{-3}$"

?

Comment thread xemc3/data/default.yaml
type: mapped
vars:
SOURCE_RAD_E:
units: W.m$^{-3}$
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
units: W.m$^{-3}$
units: "W m$^{-3}$"

or

Suggested change
units: W.m$^{-3}$
units: "eV m$^{-3}$"

?

Comment thread xemc3/data/default.yaml
Comment on lines +175 to +176
units: A.g.s$^{-1}$.m$^{-2}$
scale: 10000.0
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to switch to particle based, rather then Ampere.
So probably

Suggested change
units: A.g.s$^{-1}$.m$^{-2}$
scale: 10000.0
units: "g s$^{-1}$ m$^{-2}$"
scale: 6.242e22

Maybe we should add more SF ... or use A in the scale, so we only need to set it once?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants