Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Pester 6 format #2035

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

SqlServerDsc: Pester 6 format #2035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
6f32bf8
SqlServerDsc: Pester 6 format
johlju Jun 7, 2024
e78b2e6
Fix tests
johlju Feb 8, 2025
aa02bf5
Fix more tests
johlju Feb 8, 2025
e4766ce
Fix more tests
johlju Feb 8, 2025
6f1cb9d
Fix code before conversion
johlju Feb 9, 2025
ca74389
Fix spell check
johlju Feb 9, 2025
3a5cddf
Fix tests
johlju Feb 9, 2025
445a8a3
Fix code before conversion
johlju Feb 9, 2025
b422243
Fix test
johlju Feb 9, 2025
bebf520
Fix test
johlju Feb 9, 2025
e0163cb
Fix test
johlju Feb 9, 2025
fcac9f3
Fix tests
johlju Feb 9, 2025
dc04755
Fix tests
johlju Feb 9, 2025
c6149dc
Fix test
johlju Feb 9, 2025
dd5fc6c
Fix integ tests
johlju Feb 9, 2025
afdc725
Fix unit tests
johlju Feb 9, 2025
63bd25b
Fix tests
johlju Feb 9, 2025
ad922f4
Fix tests
johlju Feb 9, 2025
c08f1b3
fix changelog
johlju Feb 12, 2025
4144c88
fix tests to use Should-BeFalsy for Force property assertions
johlju Feb 12, 2025
f673879
Fix tests
johlju Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added

- SqlSetup
- Added new parameter ProductCoveredbySA which is introduced in SQL 2022.
- Added new parameter ProductCoveredBySA which is introduced in SQL 2022.

### Added

Expand All @@ -52,6 +52,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- SqlServerDsc
- Replaced inline task `Package_Wiki_Content` with the one now available
in the module _DscResource.DocGenerator_.
- Update tests to Pester 6 format.
- `Connect-SqlDscDatabaseEngine`
- Update comment-based help with more examples.
- SqlSetup
Expand Down
4 changes: 2 additions & 2 deletions Resolve-Dependency.psd1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
AllowPrerelease = $false
WithYAML = $true

#UseModuleFast = $true
UseModuleFast = $true
#ModuleFastVersion = '0.1.2'
#ModuleFastBleedingEdge = $true

UsePSResourceGet = $true
#UsePSResourceGet = $true
#PSResourceGetVersion = '1.0.1'

UsePowerShellGetCompatibilityModule = $true
Expand Down
76 changes: 35 additions & 41 deletions tests/Integration/Commands/Connect-SqlDscDatabaseEngine.Integration.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,25 +54,23 @@ Describe 'Connect-SqlDscDatabaseEngine' -Tag @('Integration_SQL2016', 'Integrati
It 'Should have the default instance SQL Server service started' {
$getServiceResult = Get-Service -Name 'MSSQLSERVER' -ErrorAction 'Stop'

$getServiceResult.Status | Should -Be 'Running'
$getServiceResult.Status | Should-Be 'Running'
}

Context 'When impersonating a Windows user' {
It 'Should return the correct result' {
{
$sqlAdministratorUserName = 'SqlAdmin' # Using computer name as NetBIOS name throw exception.
$sqlAdministratorPassword = ConvertTo-SecureString -String 'P@ssw0rd1' -AsPlainText -Force
$sqlAdministratorUserName = 'SqlAdmin' # Using computer name as NetBIOS name throw exception.
$sqlAdministratorPassword = ConvertTo-SecureString -String 'P@ssw0rd1' -AsPlainText -Force

$connectSqlDscDatabaseEngineParameters = @{
Credential = [System.Management.Automation.PSCredential]::new($sqlAdministratorUserName, $sqlAdministratorPassword)
Verbose = $true
ErrorAction = 'Stop'
}
$connectSqlDscDatabaseEngineParameters = @{
Credential = [System.Management.Automation.PSCredential]::new($sqlAdministratorUserName, $sqlAdministratorPassword)
Verbose = $true
ErrorAction = 'Stop'
}

$sqlServerObject = Connect-SqlDscDatabaseEngine @connectSqlDscDatabaseEngineParameters
$sqlServerObject = Connect-SqlDscDatabaseEngine @connectSqlDscDatabaseEngineParameters

$sqlServerObject.Status.ToString() | Should -Match '^Online$'
} | Should -Not -Throw
$sqlServerObject.Status.ToString() | Should-MatchString '^Online$'
}
}
}
Expand All @@ -91,47 +89,43 @@ Describe 'Connect-SqlDscDatabaseEngine' -Tag @('Integration_SQL2016', 'Integrati
It 'Should have the named instance SQL Server service started' {
$getServiceResult = Get-Service -Name 'MSSQL$DSCSQLTEST' -ErrorAction 'Stop'

$getServiceResult.Status | Should -Be 'Running'
$getServiceResult.Status | Should-Be 'Running'
}

Context 'When impersonating a Windows user' {
It 'Should return the correct result' {
{
$sqlAdministratorUserName = 'SqlAdmin' # Using computer name as NetBIOS name throw exception.
$sqlAdministratorPassword = ConvertTo-SecureString -String 'P@ssw0rd1' -AsPlainText -Force
$sqlAdministratorUserName = 'SqlAdmin' # Using computer name as NetBIOS name throw exception.
$sqlAdministratorPassword = ConvertTo-SecureString -String 'P@ssw0rd1' -AsPlainText -Force

$connectSqlDscDatabaseEngineParameters = @{
InstanceName = 'DSCSQLTEST'
Credential = [System.Management.Automation.PSCredential]::new($sqlAdministratorUserName, $sqlAdministratorPassword)
Verbose = $true
ErrorAction = 'Stop'
}
$connectSqlDscDatabaseEngineParameters = @{
InstanceName = 'DSCSQLTEST'
Credential = [System.Management.Automation.PSCredential]::new($sqlAdministratorUserName, $sqlAdministratorPassword)
Verbose = $true
ErrorAction = 'Stop'
}

$sqlServerObject = Connect-SqlDscDatabaseEngine @connectSqlDscDatabaseEngineParameters
$sqlServerObject = Connect-SqlDscDatabaseEngine @connectSqlDscDatabaseEngineParameters

$sqlServerObject.Status.ToString() | Should -Match '^Online$'
} | Should -Not -Throw
$sqlServerObject.Status.ToString() | Should-MatchString '^Online$'
}
}

Context 'When using a SQL login' {
It 'Should return the correct result' {
{
$sqlAdministratorUserName = 'sa'
$sqlAdministratorPassword = ConvertTo-SecureString -String 'P@ssw0rd1' -AsPlainText -Force

$connectSqlDscDatabaseEngineParameters = @{
InstanceName = 'DSCSQLTEST' # cSpell: disable-line
LoginType = 'SqlLogin'
Credential = [System.Management.Automation.PSCredential]::new($sqlAdministratorUserName, $sqlAdministratorPassword)
Verbose = $true
ErrorAction = 'Stop'
}

$sqlServerObject = Connect-SqlDscDatabaseEngine @connectSqlDscDatabaseEngineParameters

$sqlServerObject.Status.ToString() | Should -Match '^Online$'
} | Should -Not -Throw
$sqlAdministratorUserName = 'sa'
$sqlAdministratorPassword = ConvertTo-SecureString -String 'P@ssw0rd1' -AsPlainText -Force

$connectSqlDscDatabaseEngineParameters = @{
InstanceName = 'DSCSQLTEST' # cSpell: disable-line
LoginType = 'SqlLogin'
Credential = [System.Management.Automation.PSCredential]::new($sqlAdministratorUserName, $sqlAdministratorPassword)
Verbose = $true
ErrorAction = 'Stop'
}

$sqlServerObject = Connect-SqlDscDatabaseEngine @connectSqlDscDatabaseEngineParameters

$sqlServerObject.Status.ToString() | Should-MatchString '^Online$'
}
}
}
Expand Down
20 changes: 10 additions & 10 deletions tests/Integration/Commands/Install-SqlDscServer.Integration.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Describe 'Install-SqlDscServer' -Tag @('Integration_SQL2016', 'Integration_SQL20
Context 'When using Install parameter set' {
Context 'When installing database engine default instance' {
It 'Should run the command without throwing' {
{
$null = & ({
# Set splatting parameters for Install-SqlDscServer
$installSqlDscServerParameters = @{
Install = $true
Expand Down Expand Up @@ -141,15 +141,15 @@ Describe 'Install-SqlDscServer' -Tag @('Integration_SQL2016', 'Integration_SQL20
# (Get-ComputerName),
# $modulePath
# )
} | Should -Not -Throw
})
}

It 'Should have installed the SQL Server database engine' {
# Validate the SQL Server installation
$sqlServerService = Get-Service -Name 'MSSQLSERVER'

$sqlServerService | Should -Not -BeNullOrEmpty
$sqlServerService.Status | Should -Be 'Running'
$sqlServerService | Should-BeTruthy
$sqlServerService.Status | Should-Be 'Running'
}

It 'Should stop the default instance SQL Server service' {
Expand All @@ -165,7 +165,7 @@ Describe 'Install-SqlDscServer' -Tag @('Integration_SQL2016', 'Integration_SQL20
#>
$stopServiceResult |
Where-Object -FilterScript { $_.Name -eq 'MSSQLSERVER'}
).Status | Should -Be 'Stopped'
).Status | Should-Be 'Stopped'
}
}

Expand All @@ -176,7 +176,7 @@ Describe 'Install-SqlDscServer' -Tag @('Integration_SQL2016', 'Integration_SQL20
# }

It 'Should run the command without throwing' {
{
$null = & ({
# Set splatting parameters for Install-SqlDscServer
$installSqlDscServerParameters = @{
Install = $true
Expand Down Expand Up @@ -285,15 +285,15 @@ Describe 'Install-SqlDscServer' -Tag @('Integration_SQL2016', 'Integration_SQL20
# $modulePath
# )
# } | Should -Not -Throw
} | Should -Not -Throw
})
}

It 'Should have installed the SQL Server database engine' {
# Validate the SQL Server installation
$sqlServerService = Get-Service -Name 'MSSQL$DSCSQLTEST'

$sqlServerService | Should -Not -BeNullOrEmpty
$sqlServerService.Status | Should -Be 'Running'
$sqlServerService | Should-BeTruthy
$sqlServerService.Status | Should-Be 'Running'
}

It 'Should stop the named instance SQL Server service' {
Expand All @@ -307,7 +307,7 @@ Describe 'Install-SqlDscServer' -Tag @('Integration_SQL2016', 'Integration_SQL20
#>
$stopServiceResult |
Where-Object -FilterScript { $_.Name -eq 'MSSQL$DSCSQLTEST' }
).Status | Should -Be 'Stopped'
).Status | Should-Be 'Stopped'
}
}

Expand Down
Loading
Loading