5 fix filetransfer cleanup with only option #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…letions When force=true is used with an 'only' filter, cleanup_folder was deleting all files in the destination that weren't explicitly ignored, including unrelated folders that weren't being managed by the mapping. This caused data loss for folders like cabal/ and ghc/ that weren't in the only list. The fix adds a check for @mapping.include?(abs_path) to ensure only paths matching the inclusion filter are cleaned up, leaving unmanaged content intact. Added comprehensive test coverage: - Test for preserving unrelated folders (cabal/, ghc/) when using force + only - Test for only cleaning managed paths specified in only list - Test for edge case with empty source and unmanaged dest content - Updated existing test to reflect correct behavior (paths not in only list preserved) All 326 specs passing with 96.41% line coverage.
- Version bumped from 0.1.22 to 0.1.23 - Updated CHANGELOG.md with critical bug fix details - Updated Gemfile.lock with new version - All 326 specs passing with 96.41% line coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5