chore: bump tholos-sdk's stellar-sdk dependency to ^16.2.0 - #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #92's follow-up (flagged in that PR's review discussion): bumps
packages/tholos-sdk's@stellar/stellar-sdkdependency from^14.5.0to^16.2.0.^14.5.0was never a deliberate pin, it was just whatever version the Stellar CLI's codegen template defaulted to when the SDK bindings were originally generated in #60. Oncedemos/freelance-escrowstarted depending ontholos-sdkdirectly (#92), its previous direct@stellar/stellar-sdk ^16.2.0dependency got dropped as redundant, and the transitive version resolved down totholos-sdk's older^14.5.0pin instead. Tested whether bumping would actually break anything before doing it; it doesn't.Bonus:
demos/freelance-escrow'stholosbundle chunk shrinks from 1,735 kB to 369 kB (480 kB to 98 kB gzipped) with the newer version, apparently from cleaner tree-shaking.Test plan
pnpm build(tsc) passes inpackages/tholos-sdkfrom a clean install against^16.2.0pnpm lintandpnpm buildboth pass indemos/freelance-escrowfrom a clean install against the bumped SDK, with no code changes needed on either sideCONTRACT.md/scripts/testnet-smoke.sh— not applicable, this only touches a JS dependency version