docs: rewrite wallet section around WalletAdapter - #522
Conversation
|
@GazzyLee is attempting to deploy a commit to the Collins' projects Team on Vercel. A member of the Team first needs to authorize it. |
collinsezedike
left a comment
There was a problem hiding this comment.
The PR title is cut off mid-word (...drop connectFreighte…), and the commit message header is 82 characters, over the 72-character limit enforced by the commit message ruleset. Since squash merge is enforced, the PR title becomes the final commit message (see CONTRIBUTING.md's Commit Convention section), so please fix the title itself, not just the commit, and keep it at or under 72 characters.
304ccbd to
4742e90
Compare
There was a problem hiding this comment.
@GazzyLee the PR title is still truncated. This hasn't been updated since the earlier review. Please fix the title itself, since it becomes the squash commit message on merge.
collinsezedike
left a comment
There was a problem hiding this comment.
I have fixed the title myself.
@GazzyLee Thank you for your contribution. Your PR matches the WalletAdapter flow accurately.
Feel free to pick up another open issue if you're interested.
Merging now.
Summary
Updates
apps/docs/architecture/frontend.mdto reflect the wallet abstraction layer introduced in the "feat(web): extract wallet abstraction layer from Freighter flow" commit.The doc previously claimed connection goes through
connectFreighter(), which no longer exists. Callers now depend on theWalletAdapterinterface (apps/web/src/lib/wallet.ts), implemented today only byFreighterWallet.Motivation
connectFreighter()is confirmed absent fromapps/web/src.useWalletConnectnow callswallet.connect()on aFreighterWallet.Changes
useWalletConnectcallswallet.isInstalled()→wallet.connect(), then persists the public key.wallet.isAuthorized().WalletAdapterinterface and how a new wallet is added (newWalletAdapterimplementation + selection inwallet.ts, no caller changes).connectFreighter()reference.Acceptance Criteria
frontend.mdwallet section reflectswallet.connect()viaWalletAdapter, notconnectFreighter()WalletAdapterinterface and how a new wallet gets addedconnectFreighter()Scope
Closes #521