use type name in Display impl for errors with no other message set #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, with nested errors, you can end up with unhelpful errors like
this (example printed by `anyhow`):
```
Error: failed to get metadata for "/temp/spoopadoop"
Caused by:
0: Dropbox API endpoint returned an error: There is nothing at the given path.
1: There is nothing at the given path.
2: There is nothing at the given path.
```
instead, with this change, you get:
```
Error: failed to get metadata for "/temp/spoopadoop"
Caused by:
0: Dropbox API endpoint returned an error: GetMetadataError: There is nothing at the given path.
1: GetMetadataError: There is nothing at the given path.
2: There is nothing at the given path.
```
which is less repetitive and gives a better indication of what actually went wrong.
Older rust has a broken half-implementation of MSRV support, in that `cargo update` (or when no lockfile is present) will grab the lastest package, ignoring its MSRV, yet immediately complain that it can't build said package because its MSRV is too high.
wfraser
force-pushed
the
error-msg-type-name
branch
from
7257340 to
a851425
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, with nested errors, you can end up with unhelpful errors like this (example printed by
anyhow):instead, with this change, you get:
which is less repetitive and gives a better indication of what actually went wrong.
Checklist
General Contributing
RELEASE_NOTES.mdfile, or believe it's not necessary for this change.Validation
This affects display of errors only; no other behavior change. Display impls are not a fixed format and changes to them shouldn't break things.