Skip to content

Fix NodeStatus flooding and GUI responsiveness issues #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix NodeStatus flooding and GUI responsiveness issues #88

wants to merge 2 commits into from

Conversation

Bwooce
Copy link

@Bwooce Bwooce commented Jul 26, 2025 •
edited
Loading

Summary

  • Fix scheduler feedback loop causing 6000+ NodeStatus messages per second flooding the CAN bus
  • Fix GUI responsiveness by limiting frames processed per spin(0) call to prevent infinite loops
  • Maintain proper periodic timing while preventing callback overlap

Technical Details

  • Scheduler Fix: Prevent callback overlap in periodic scheduler that was causing runaway NodeStatus generation when callbacks took longer than the period
  • GUI Fix: Limit spin(0) to process maximum 100 frames per call to prevent GUI thread blocking

@Bwooce Bwooce changed the title Rate limiting only Rate limiting on NodeStatus messages from DroneCAN GUI Jul 26, 2025
@Bwooce Bwooce mentioned this pull request Jul 26, 2025
Open
Fix NodeStatus message flooding caused by scheduler feedback loop
383ce8e 
When SLCAN ACK/NACK waits were removed to support adapters without
confirmation, the scheduler's timing assumptions broke. The periodic
scheduler would re-register the next NodeStatus event before the
current callback completed, causing a runaway loop when SLCAN frame
transmission included time.sleep() calls.

This fix prevents callback overlap by:
- Adding callback_running flag to track execution state
- Skipping overlapping executions and rescheduling for next period
- Using try/finally to ensure flag is always reset

Resolves 6000+ NodeStatus messages/second flooding issue while
maintaining proper 1Hz timing and DroneCAN compliance.
@Bwooce Bwooce force-pushed the rate-limiting-only branch from f384a34 to 383ce8e Compare July 26, 2025 13:16
@Bwooce Bwooce changed the title Rate limiting on NodeStatus messages from DroneCAN GUI Fix NodeStatus message flooding caused by scheduler feedback loop Jul 26, 2025
@Bwooce
Copy link
Author

Bwooce commented Jul 27, 2025

Apologies for the churn here, on further testing there were...more problems. I've attempted to keep this PR seperate from the ACK/NACK change one to facilitate testing/validation that it's not broken the world before the ACK/NACK change gets merged.

@Bwooce Bwooce changed the title Fix NodeStatus message flooding caused by scheduler feedback loop Fix NodeStatus flooding and GUI responsiveness issues Jul 27, 2025
@Bwooce
Fix scheduler callback overlap and improve transfer management
d9acd2e 
- Fix periodic scheduler callback overlap preventing NodeStatus flooding
- Add GUI responsiveness protection by limiting frames per spin cycle
- Improve transfer reassembly with proactive cleanup and shorter timeouts
- Fix dictionary iteration bug in transfer cleanup

These changes resolve NodeStatus flooding and GUI freezing issues
while improving frame decode reliability.
@Bwooce Bwooce force-pushed the rate-limiting-only branch from a1794f7 to d9acd2e Compare July 27, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Bwooce