Add path support different than root #344
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drone expected that everything will be served on the web root. This patch
enables support from another path than root. The `index.html` will load the
resources relatives to its path. A `window.BASE_URL` variable can be set by
the backend to specify the path for routes and the API endpoint.
The next commits will fix hard-coded url and paths.
Fixes #306
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add path support different than root
Drone expected that everything will be served on the web root. This patch
enables support from another path than root. The
index.htmlwill load theresources relatives to its path. A
window.BASE_URLvariable can be set bythe backend to specify the path for routes and the API endpoint.
Fixes #306