Skip to content

04 weather client #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mr-SlavaK wants to merge 25 commits into
base: master
Choose a base branch
from
Open

04 weather client #9

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
c09e2dd
First practice (Bob)
Nov 14, 2018
104b9d6
Merge remote-tracking branch 'upstream/master'
Nov 19, 2018
1d7fe3c
Added 00_intro to the project
Nov 19, 2018
7685d73
Second practice
Nov 27, 2018
b15d2ff
Anagram task added
Dec 4, 2018
ead3e32
Practical class
Dec 18, 2018
f193060
Class work
Jan 8, 2019
e7c70e8
Invalid parsing red test
Jan 8, 2019
84a36ac
Invalid parsing green test
Jan 8, 2019
e8ad60e
Invalid parsing refactoring test
Jan 8, 2019
083b310
Get average temp acceptence test
Jan 8, 2019
c7b7b0a
Get average temp acceptence test (updated)
Jan 8, 2019
654f169
Get min temp red test
Jan 8, 2019
98e7bf3
Get min temp green test
Jan 8, 2019
2cdaa0c
Get min temp acceptence test
Jan 8, 2019
3e9759a
Get max temp red test
Jan 8, 2019
7956639
Get max temp green test
Jan 8, 2019
ffe8e07
Get max temp acceptence test (+ fix for min acceptence test)
Jan 8, 2019
9be1241
Get average wind direction red test
Jan 8, 2019
8d89718
Get average wind direction green test
Jan 8, 2019
d238b5f
Get average wind direction acceptence test
Jan 8, 2019
7caf78f
Get max wind speed red test
Jan 8, 2019
266e8b7
Get max wind speed green test
Jan 8, 2019
00b5ba8
Get max wind speed acceptence test
Jan 8, 2019
83ab163
Little final refactorng
Jan 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions tdd_intro/homework/04_weather_client/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ class IWeatherClient
public:
virtual ~IWeatherClient() { }
virtual double GetAverageTemperature(IWeatherServer& server, const std::string& date) = 0;
// virtual double GetMinimumTemperature(IWeatherServer& server, const std::string& date) = 0;
virtual short GetMinimumTemperature(IWeatherServer& server, const std::string& date) = 0;
// virtual double GetMaximumTemperature(IWeatherServer& server, const std::string& date) = 0;
// virtual double GetAverageWindDirection(IWeatherServer& server, const std::string& date) = 0;
// virtual double GetMaximumWindSpeed(IWeatherServer& server, const std::string& date) = 0;
Expand Down Expand Up @@ -144,6 +144,22 @@ class WeatherClient : public IWeatherClient

return result/4;
}

short GetMinimumTemperature(IWeatherServer& server, const std::string& date)
{
std::vector<short> temps;
std::string response = server.GetWeather(date + ";03:00");
temps.push_back(ParseWeather(response).temperature);
response = server.GetWeather(date + ";09:00");
temps.push_back(ParseWeather(response).temperature);
response = server.GetWeather(date + ";15:00");
temps.push_back(ParseWeather(response).temperature);
response = server.GetWeather(date + ";21:00");
temps.push_back(ParseWeather(response).temperature);
Copy link
Collaborator

@prepas prepas Jan 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

строчки для получения температуры по времени почти повторяются с GetAverageTemperature, нет рефакторинга, где этот код можно вынести в отдельный мето


std::vector<short>::iterator result = std::min_element(std::begin(temps), std::end(temps));
return *result;
}
};

Weather ParseWeather(const std::string &data)
Expand Down Expand Up @@ -266,5 +282,5 @@ TEST(WeatherClient, GetMinimumTemperatureFor31_08_2018)
WeatherServerStub server;
WeatherClient client;

ASSERT_FLOAT_EQ(25.5f, client.GetMinimumTemperature(server, "31.08.2018"));
ASSERT_EQ(20, client.GetMinimumTemperature(server, "31.08.2018"));
}