Skip to content

01 leap year #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mr-SlavaK wants to merge 16 commits into
base: master
Choose a base branch
from
Open

01 leap year #3

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c09e2dd
First practice (Bob)
Nov 14, 2018
104b9d6
Merge remote-tracking branch 'upstream/master'
Nov 19, 2018
1d7fe3c
Added 00_intro to the project
Nov 19, 2018
e54945c
First red test
Nov 19, 2018
3107554
First green test
Nov 19, 2018
851788a
First refactoring
Nov 19, 2018
b7b6142
First red test
Nov 27, 2018
7cb5685
First green test
Nov 27, 2018
dd1a0b9
First refactoring
Nov 27, 2018
30706a5
Second red test
Nov 27, 2018
f0dd1c9
Second green test
Nov 27, 2018
583ef8c
Second refactoring
Nov 27, 2018
8dcd2b3
Third red test
Nov 27, 2018
d18e3bd
Third green test
Nov 27, 2018
1cd1253
Third refactoring
Nov 27, 2018
3d38518
Acceptence test
Nov 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tdd_intro/homework/01_leap_year/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,11 @@ TEST(LeapYear, DivisibleBy4ExceptDivisibleBy100UnlessDivisibleBy400)
{
ASSERT_TRUE(IsLeapYear(2000));
}

TEST(LeapYear, Acceptence)
Copy link
Collaborator

@prepas prepas Nov 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

перед этим тестом не хватило рефакторинга, функция в итоге может быть такой
return (year % 4 == 0) && (year % 100 != 0)) || (year % 400 == 0);

{
ASSERT_TRUE(IsLeapYear(2020));
ASSERT_TRUE(IsLeapYear(2008));
ASSERT_FALSE(IsLeapYear(1990));
ASSERT_FALSE(IsLeapYear(1000));
}