Skip to content

Ternary number #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dariatdd wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Ternary number #8

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
eaaeefa
2: red
dariatdd Oct 11, 2018
c71f734
2: green
dariatdd Oct 11, 2018
c3c913d
2: refactored
dariatdd Oct 11, 2018
11776e0
2: red
dariatdd Oct 11, 2018
276348b
2: green
dariatdd Oct 11, 2018
072f36b
2: red
dariatdd Oct 11, 2018
65d170a
2: for previous commit
dariatdd Oct 11, 2018
24d23ef
2: green
dariatdd Oct 11, 2018
02a4be6
2: refactored
dariatdd Oct 11, 2018
743ea9e
2: red
dariatdd Oct 11, 2018
e379273
2: green
dariatdd Oct 11, 2018
f8d79bf
2: refactored
dariatdd Oct 11, 2018
0f1b526
2: red
dariatdd Oct 11, 2018
2584a42
2: green
dariatdd Oct 11, 2018
beb6305
2: refactored
dariatdd Oct 11, 2018
0aa20e1
2: added acceptance tests
dariatdd Oct 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tdd_intro/homework/02_ternary_numbers/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,8 @@ TEST(TernaryNumber, OneConvertsToOneTest)
{
EXPECT_EQ(1, ConvertTernaryToDecimal("1"));
}

TEST(TernaryNumber, ConvertValidTernaryNumberTest)
{
EXPECT_EQ(5, ConvertTernaryToDecimal("012"));
Copy link
Collaborator

@Krestol Krestol Oct 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно было сначала добавить тест на невалидное значение.
Шаг выглядит великоватым.

Copy link
Collaborator

@Krestol Krestol Oct 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • перед этим тестом нужен был тест с пустой строкой

}