feat: skip slot validation for durable nonce txs (Fireblocks)#114
Open
drift-internal-ai-bot[bot] wants to merge 1 commit intomasterfrom
Open
feat: skip slot validation for durable nonce txs (Fireblocks)#114drift-internal-ai-bot[bot] wants to merge 1 commit intomasterfrom
drift-internal-ai-bot[bot] wants to merge 1 commit intomasterfrom
Conversation
… support) Custodial wallets like Fireblocks replace the recentBlockhash with a durable nonce, making transactions valid beyond the normal ~151 slot window. This change detects durable nonce transactions by checking for an AdvanceNonceAccount instruction as the first instruction (Solana protocol convention) and skips the 500-slot expiry check for them. Changes: - Add is_durable_nonce_tx() to detect durable nonce transactions - Add skip_slot_validation parameter to validate_order and extract_signed_message_info - In deposit_trade, auto-detect durable nonce from deposit tx - Add tests for durable nonce detection and slot validation skip Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Fireblocks (and other custodial wallets) replace the recentBlockhash with a durable nonce before signing, making transactions valid beyond the normal ~151 slot window. Swift current 500-slot expiry check (taker_slot < current_slot - 500) would reject these transactions as slot too old even though they are still valid.
The detection is tamper-proof: the AdvanceNonceAccount instruction is part of the signed transaction and cannot be faked.
Note: This only covers the /depositTrade path where a VersionedTransaction is available. The /orders path (signed messages only, no transaction) still uses the 500-slot check. If custodial wallet users also need extended validity for signed-message-only orders, that would need a separate approach.
Relates to BE-256
Test plan