feat: add trigger order support (TriggerMarket, TriggerLimit)#113
Open
ChesterSim wants to merge 2 commits intomasterfrom
Open
feat: add trigger order support (TriggerMarket, TriggerLimit)#113ChesterSim wants to merge 2 commits intomasterfrom
ChesterSim wants to merge 2 commits intomasterfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Trigger orders with valid auction params pass through the auction validation branch (same as limit orders), so asserting they fail with InvalidOrderAuction was wrong. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OrderType::TriggerMarketandOrderType::TriggerLimittovalidate_signed_order_paramsallowed order typesTest plan
test_validate_trigger_order_paramspasses — TriggerMarket/TriggerLimit accepted without auction paramstest_validate_trigger_order_paramspasses — TriggerMarket/TriggerLimit rejected with auction params🤖 Generated with Claude Code