feat: support trigger orders and oracle-offset limit orders#112
Closed
ChesterSim wants to merge 6 commits intomasterfrom
Closed
feat: support trigger orders and oracle-offset limit orders#112ChesterSim wants to merge 6 commits intomasterfrom
ChesterSim wants to merge 6 commits intomasterfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Add OrderTriggerCondition and PostOnlyParam imports. Refactor validate_signed_order_params into router + validate_market_order_params, validate_limit_order_params, and placeholder trigger validators. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_signed_order_paramsinto a router dispatching to per-order-type validator functions (validate_market_order_params,validate_limit_order_params,validate_trigger_market_order_params,validate_trigger_limit_order_params)oracle_price_offset != 0) with oracle auction param validation (direction-aware offset ordering)Test plan
cargo test test_validateto verify all 23 new test cases pass (4 new test functions)test_validate_market_type,test_validate_order_size,test_validate_auction_paramstests still pass🤖 Generated with Claude Code