feat: add trigger order support to SwiftPlacer#598
Open
ChesterSim wants to merge 5 commits intomasterfrom
Open
feat: add trigger order support to SwiftPlacer#598ChesterSim wants to merge 5 commits intomasterfrom
ChesterSim wants to merge 5 commits intomasterfrom
Conversation
Orders without auction params (trigger/limit) now bypass the fill flow and are placed on-chain directly, with triggerPrice validation for triggerMarket/triggerLimit orders. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
- Use explicit != null checks for hasAuctionParams to avoid falsy-zero trap on auctionDuration=0 - Forward preDepositTx in place-only path with same fire-and-forget pattern as auction path - Allow pre-deposit orders to bypass sim errors in place-only path (race condition) - Remove dead !signedMsgOrderParams.price guard since price is typed as BN (non-nullable) Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
… orders Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prettyPrintOrderParamsto log trigger-relevant fields (triggerPrice, triggerCondition) for non-auction ordersTest plan
🤖 Generated with Claude Code