refactor(common-ts): add oracle limit order support for swift#330
Merged
ChesterSim merged 1 commit intomasterfrom Mar 30, 2026
Merged
Conversation
Contributor
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds oracle limit order support for Swift perp orders. Previously, Swift only accepted
limitorder types — this extends it to also supportoracleLimit, which uses an oracle price offset instead of a fixed limit price.Changes
OracleLimitOrderParamsOrderConfigincommon-ts/src/drift/base/actions/trade/openPerpOrder/types.ts— defines the oracle limit order config withoraclePriceOffsetfieldSwiftLimitOrderParamsOrderConfig—LimitOrderParamsOrderConfig | OracleLimitOrderParamsOrderConfig, used wherever Swift limit orders are acceptedprepSwiftLimitOrderDatainopenPerpNonMarketOrder/index.ts— branches onorderConfig.orderTypeto handlelimitvsoracleLimitwith different order param construction (limit price vs oracle price offset)CentralServerDrift/index.tsandopenPerpNonMarketOrder/index.ts— error messages now accept'limit'or'oracleLimit'bracketOrdersare now returned fromprepSwiftLimitOrderDataand passed through explicitly rather than accessed fromorderConfigdirectlyTest plan
oraclePriceOffsetbunx tsc --noEmitincommon-ts