Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement : Remove the auto power of for some tuya switch #5118

Closed
wants to merge 19 commits into from

Conversation

Smanar
Copy link
Collaborator

@Smanar Smanar commented Jul 14, 2021

It seem there is a problem in the firmware on some model like

  • _TZ3000_fvh3pjaz
  • _TZ3000_9hpxg80k
  • _TZ3000_wyhuocal

This PR just disable the auto power off, see #3693

@Smanar Smanar linked an issue Jul 14, 2021 that may be closed by this pull request
@manup
Copy link
Member

manup commented Jul 17, 2021

The manufacturer names are not yet listed in product_match.cpp. I'd suggest to add them there and use R_GetProductId().

@Smanar
Copy link
Collaborator Author

Smanar commented Jul 17, 2021

Done, but the problem is it s not possible to find something specific to device, some of them haven't model reference or mutiple brand (X711A, X712A, Lonsonho or tuya or Zemismart, ect ...) and some model have same reference, but 2 versions, the bugged one and the not bugged (with different manufacture name)

So have used a standard description and a suffix, to not mix them with not bugged one.

    {"_TZ3000_fvh3pjaz", "TS0012", "Tuya", "Tuya_SWITCH 2 Gangs (T)"},
    {"_TZ3000_9hpxg80k", "TS0011", "Tuya", "Tuya_SWITCH 1 Gangs (T)"},
    {"_TZ3000_wyhuocal", "TS0013", "Tuya", "Tuya_SWITCH 3 Gangs (T)"},

@mpeterson
Copy link

@manup Is there something holding up the merge of this patch? as it can be seen in the related incident there is a number of people affected by this issue and DDF has not proven to be helpful to fix it (at least when I tried)

@Mimiix
Copy link
Collaborator

Mimiix commented Jan 11, 2022

@mpeterson It probably gets merged right before 2.14.0 comes out

@donok1
Copy link

donok1 commented Feb 7, 2022

Hi @Mimiix, like @mpeterson I'm waiting for the merge.
Anything we can do to speed this up ?

@Mimiix
Copy link
Collaborator

Mimiix commented Feb 7, 2022

@donok1 please check #5733

@donok1
Copy link

donok1 commented Feb 7, 2022

@donok1 please check #5733

Thanks for the link, I missed it.
I completely support the idea. Hard coding each device is definitely not the way to go

But it's too bad this 7 month request was not met before the change of strategy, specially knowing that all tests using DDF for these switches have failed until now...

@Mimiix
Copy link
Collaborator

Mimiix commented Feb 7, 2022

@manup Is the only one able to answer here.

@mpeterson
Copy link

@Mimiix @manup Here we have an issue with functionality that affects many people, for which DDF has not been enough (I can check again if there were updates to DDF since my tests), and for which a verified fix exists (this PR).

I agree with @donok1 points of view. This could have fixed users pains a long time ago and because of other considerations was decided to not be merged, while not providing a viable alternative.

From my side, I have a full house of this switches sitting in a box waiting for this fix and it's a blocker for being installed at home.

Could we consider merging this if DDF is not a viable alternative at this point?

@Mimiix
Copy link
Collaborator

Mimiix commented Feb 7, 2022

I have no clue why it's not merged yet. Asked Manuel to reply here.

Nevertheless : what stops you from compiling yourself?

@mpeterson
Copy link

@Mimiix I'm using deconz as a Home-Assistant Supervisor Add-On. That would break the flow that me and many others are using. Manually compiling moves the flow from stable and maintained deployment to a custom one.

Plus, not everyone has the knowledge to compile and maintain their own deployments.

@Mimiix
Copy link
Collaborator

Mimiix commented Feb 7, 2022

@Mimiix I'm using deconz as a Home-Assistant Supervisor Add-On. That would break the flow that me and many others are using. Manually compiling moves the flow from stable and maintained deployment to a custom one.

Plus, not everyone has the knowledge to compile and maintain their own deployments.

The only thing i'm saying is that if you are waiting for it that badly, you can solve it with compiling yourself.
This is the reason i stopped using the addon though. I can still use HA With my deCONZ but it just is installed on another VM. That's what the integration is for.

Other than advicing that there's nothing i can do now. Manuel will respond later on.

@jonnipee
Copy link

Honestly this is also quite frustrating for me too. I did a lot of testing with smanar ages ago and I have been patiently waiting for it to be merged.

@Smanar
Copy link
Collaborator Author

Smanar commented Feb 28, 2022

And we have tried, it don't work using DDF (make a DDF without the binding part)

@mpeterson
Copy link

@manup is there a chance you can chip in here? This is a very frustrating issue for both users and contributors like @Smanar that dedicated own time for the improvement that never saw the light

@manup
Copy link
Member

manup commented Mar 27, 2022

Hi the code in the PR shouldn't be needed anymore. If the DDF is active for these manufacturer names the function bails out directly:

Device *device = DEV_GetDevice(m_devices, lightNode->address().ext());
if (device && device->managed())
{
return;
}

@mpeterson
Copy link

@manup I just tried today using deconz 2.14.1 and the DDF still doesn't seem to be working. Either I'm doing something wrong or the DDF is not behaving like expected.

The following screenshot shows how the DDF was configured. After doing that I did a hot reload. Is there a way to know if it was in fact loaded as configured? Because the device still behaves incorrectly after removing those bindings.

image

@mpeterson
Copy link

@manup I see that it seems to have loaded it (as per screenshot), yet the bad behavior still replicates

image

@Smanar
Copy link
Collaborator Author

Smanar commented Mar 27, 2022

Ha yes the code need to work as it
Perhaps it s because the binding is already done before. Have you tried with a new inclusion ?

@manup
Copy link
Member

manup commented Mar 29, 2022

Perhaps it s because the binding is already done before. Have you tried with a new inclusion ?

Yes that would also be my assumption, to test this the easiest way the device could be deleted + reset and joined again.

@mpeterson
Copy link

mpeterson commented Mar 29, 2022 via email

@HA-Jon
Copy link

HA-Jon commented Apr 16, 2022

TS0013
by _TZ3000_wyhuocal
Lonsonho
I'm using a Conbee stick via Home Assistant. How can I fix my light-switch?

@Smanar
Copy link
Collaborator Author

Smanar commented Apr 17, 2022

Hello can you try to make a DDF file to use with your device ? https://github.com/dresden-elektronik/deconz-rest-plugin/wiki/DDF-cheat-sheet

If I m right you just need to select "edit DDF" and all values will be filled (and bind are not created on DDF)
So after that set the status to gold, save the file and re-include the device.

@HA-Jon
Copy link

HA-Jon commented Apr 17, 2022

How?
I've not got access to the physical item.

@Smanar
Copy link
Collaborator Author

Smanar commented Apr 17, 2022

Ha ? the device is not reconized by deconz ?
This issue if for the "auto power off" problem.

@HA-Jon
Copy link

HA-Jon commented Apr 17, 2022

It is the "Auto power off after 2 minutes PROBLEM". I was just explaining how I use the switch.

@Smanar
Copy link
Collaborator Author

Smanar commented Apr 17, 2022

So try with a DDF, theorically the use of a DDF can solve the issue.

@jonnipee
Copy link

jonnipee commented Apr 17, 2022 via email

@Smanar Smanar closed this Dec 22, 2023
@Smanar Smanar deleted the tuya_test_1 branch December 22, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tuya Double Switch TS0012 turns itself off again.
7 participants