-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement : Remove the auto power of for some tuya switch #5118
Conversation
The manufacturer names are not yet listed in |
Done, but the problem is it s not possible to find something specific to device, some of them haven't model reference or mutiple brand (X711A, X712A, Lonsonho or tuya or Zemismart, ect ...) and some model have same reference, but 2 versions, the bugged one and the not bugged (with different manufacture name) So have used a standard description and a suffix, to not mix them with not bugged one.
|
This reverts commit d51aa1a.
@manup Is there something holding up the merge of this patch? as it can be seen in the related incident there is a number of people affected by this issue and DDF has not proven to be helpful to fix it (at least when I tried) |
@mpeterson It probably gets merged right before 2.14.0 comes out |
Hi @Mimiix, like @mpeterson I'm waiting for the merge. |
Thanks for the link, I missed it. But it's too bad this 7 month request was not met before the change of strategy, specially knowing that all tests using DDF for these switches have failed until now... |
@manup Is the only one able to answer here. |
@Mimiix @manup Here we have an issue with functionality that affects many people, for which DDF has not been enough (I can check again if there were updates to DDF since my tests), and for which a verified fix exists (this PR). I agree with @donok1 points of view. This could have fixed users pains a long time ago and because of other considerations was decided to not be merged, while not providing a viable alternative. From my side, I have a full house of this switches sitting in a box waiting for this fix and it's a blocker for being installed at home. Could we consider merging this if DDF is not a viable alternative at this point? |
I have no clue why it's not merged yet. Asked Manuel to reply here. Nevertheless : what stops you from compiling yourself? |
@Mimiix I'm using deconz as a Home-Assistant Supervisor Add-On. That would break the flow that me and many others are using. Manually compiling moves the flow from stable and maintained deployment to a custom one. Plus, not everyone has the knowledge to compile and maintain their own deployments. |
The only thing i'm saying is that if you are waiting for it that badly, you can solve it with compiling yourself. Other than advicing that there's nothing i can do now. Manuel will respond later on. |
Honestly this is also quite frustrating for me too. I did a lot of testing with smanar ages ago and I have been patiently waiting for it to be merged. |
And we have tried, it don't work using DDF (make a DDF without the binding part) |
Hi the code in the PR shouldn't be needed anymore. If the DDF is active for these manufacturer names the function bails out directly: deconz-rest-plugin/bindings.cpp Lines 2488 to 2492 in 6ec6ff4
|
@manup I just tried today using deconz 2.14.1 and the DDF still doesn't seem to be working. Either I'm doing something wrong or the DDF is not behaving like expected. The following screenshot shows how the DDF was configured. After doing that I did a hot reload. Is there a way to know if it was in fact loaded as configured? Because the device still behaves incorrectly after removing those bindings. |
@manup I see that it seems to have loaded it (as per screenshot), yet the bad behavior still replicates |
Ha yes the code need to work as it |
Yes that would also be my assumption, to test this the easiest way the device could be deleted + reset and joined again. |
I’ll test this on Friday and report back.
…On Tue, Mar 29, 2022, at 19:40, Manuel Pietschmann wrote:
> Perhaps it s because the binding is already done before. Have you tried with a new inclusion ?
>
Yes that would also be my assumption, to test this the easiest way the device could be deleted + reset and joined again.
—
Reply to this email directly, view it on GitHub <#5118 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAC4XVT4GHI545YRL7DP7DVCMW77ANCNFSM5AK3V66A>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
Michel Peterson
|
TS0013 |
Hello can you try to make a DDF file to use with your device ? https://github.com/dresden-elektronik/deconz-rest-plugin/wiki/DDF-cheat-sheet If I m right you just need to select "edit DDF" and all values will be filled (and bind are not created on DDF) |
How? |
Ha ? the device is not reconized by deconz ? |
It is the "Auto power off after 2 minutes PROBLEM". I was just explaining how I use the switch. |
So try with a DDF, theorically the use of a DDF can solve the issue. |
Hmm I need to try this and see if it works also.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Smanar ***@***.***>
Sent: Sunday, April 17, 2022 4:28:02 PM
To: dresden-elektronik/deconz-rest-plugin ***@***.***>
Cc: Jonathan Prasad ***@***.***>; Manual ***@***.***>
Subject: Re: [dresden-elektronik/deconz-rest-plugin] Improvement : Remove the auto power of for some tuya switch (#5118)
So try with a DDF, theorically the use of a DDF can solve the issue.
—
Reply to this email directly, view it on GitHub<#5118 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AN2UGUN2N5NR7H7KZWRZEMLVFQGWFANCNFSM5AK3V66A>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
It seem there is a problem in the firmware on some model like
This PR just disable the auto power off, see #3693