Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add $ after sk change #4506

Closed
wants to merge 1 commit into from
Closed

fix: add $ after sk change #4506

wants to merge 1 commit into from

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

Playwright test results

passed  23 passed

Details

stats  23 tests across 10 suites
duration  5 minutes, 10 seconds
commit  1fdb416
info  For more information, see full report

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 32.68%. Comparing base (5d0b397) to head (1fdb416).
Report is 59 commits behind head on dev.

Files with missing lines Patch % Lines
...i/src/services/canvas-float-dom-manager.service.ts 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4506      +/-   ##
==========================================
+ Coverage   32.67%   32.68%   +0.01%     
==========================================
  Files        2597     2597              
  Lines      134527   134538      +11     
  Branches    29925    29927       +2     
==========================================
+ Hits        43954    43975      +21     
+ Misses      90573    90563      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku closed this Feb 5, 2025
@jikkai jikkai deleted the fix/float-dom-update branch February 5, 2025 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant