Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: customize auto height for merged cell #4488

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Jan 15, 2025

close #4445

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jan 15, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

Playwright test results

passed  23 passed

Details

stats  23 tests across 10 suites
duration  5 minutes, 8 seconds
commit  98e8a82
info  For more information, see full report

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 32.67%. Comparing base (930e15f) to head (98e8a82).

Files with missing lines Patch % Lines
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 17 Missing ⚠️
packages/sheets/src/sheets-plugin.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4488      +/-   ##
==========================================
- Coverage   32.68%   32.67%   -0.01%     
==========================================
  Files        2597     2597              
  Lines      134555   134571      +16     
  Branches    29940    29945       +5     
==========================================
+ Hits        43975    43976       +1     
- Misses      90580    90595      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku requested a review from jikkai January 15, 2025 09:12
@lumixraku lumixraku force-pushed the feat/customize-autoheight branch 2 times, most recently from e6a6c6b to 71d313a Compare January 16, 2025 10:08
@lumixraku lumixraku force-pushed the feat/customize-autoheight branch from 71d313a to d33b586 Compare January 18, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] The height of merged cells can be adjusted automatically.
1 participant