Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): formula update after hide row column #4238

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Dec 5, 2024

What's updated?

Hiding rows (manually or by filtering) affects the SUBTOTAL formula

How to test?

e.g.

before (dev version)

image

after

image

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 5, 2024

Playwright test results

failed  1 failed
passed  21 passed

Details

stats  22 tests across 11 suites
duration  5 minutes, 24 seconds
commit  d2ad3f7
info  For more information, see full report

Failed tests

chromium › visual-comparison/sheets/sheets-formula-related.spec.ts › diff formula related

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 8.13953% with 79 lines in your changes missing coverage. Please review.

Project coverage is 32.76%. Comparing base (2ec2c5e) to head (d2ad3f7).

Files with missing lines Patch % Lines
...ilter/src/services/sheet-filter-formula.service.ts 0.00% 22 Missing ⚠️
...es/engine-formula/src/models/formula-data.model.ts 10.00% 18 Missing ⚠️
...formula/src/controllers/active-dirty.controller.ts 0.00% 17 Missing ⚠️
...ngine-formula/src/services/current-data.service.ts 23.52% 13 Missing ⚠️
.../src/controllers/trigger-calculation.controller.ts 0.00% 5 Missing ⚠️
...rmula/src/controllers/update-formula.controller.ts 0.00% 2 Missing ⚠️
...ine-formula/src/controller/calculate.controller.ts 0.00% 1 Missing ⚠️
packages/sheets-filter/src/plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4238      +/-   ##
==========================================
- Coverage   32.77%   32.76%   -0.02%     
==========================================
  Files        2561     2562       +1     
  Lines      132929   132990      +61     
  Branches    29600    29608       +8     
==========================================
+ Hits        43568    43571       +3     
- Misses      89361    89419      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir force-pushed the dushusir/formula1205 branch 2 times, most recently from a087219 to 533cd0f Compare December 7, 2024 03:52
@Dushusir Dushusir marked this pull request as ready for review December 7, 2024 03:52
@Dushusir Dushusir requested review from DR-Univer, wpxp123456 and wzhudev and removed request for VicKun4937, wzhudev, yuhongz, ybzky and DR-Univer December 7, 2024 03:53
@Dushusir Dushusir added the qa:untested This PR is ready to be tested label Dec 7, 2024
@Dushusir Dushusir requested a review from DR-Univer December 7, 2024 03:57
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Dec 13, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Dec 13, 2024
@Dushusir Dushusir force-pushed the dushusir/formula1205 branch from de32844 to d2ad3f7 Compare January 7, 2025 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants