"Fix button logic for nullable/not nullable toggle — Update button behavior for better clarity" #407
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@R-Pavan-2503 is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1ilit
requested changes
Apr 13, 2025
| theme={data.notNull ? "solid" : "light"} | ||
|
|
||
| type={data.notNull ? "tertiary" : "primary"} | ||
| title={t("Nullable")} |
There was a problem hiding this comment.
can you just add the 'nullable' key to en.js, and use it here
|
@1ilit I have done the commented changes ! |
1ilit
approved these changes
Apr 14, 2025
ewqazxc
pushed a commit
to ewqazxc/drawdb
that referenced
this pull request
Apr 15, 2025
* Fix button behavior: Reverse logic for nullable/not nullable toggle * fix: updated translation key to 'nullable' and refactored button title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
-Before the fix, the "?" button in the column settings had a confusing behavior. When it was activated (blue), it actually meant the field was "not nullable," and when deactivated (grey), it meant the field was "nullable." This reversed logic caused some confusion for users, as the button's appearance didn't match the actual field state.
After:
After the fix, the button now behaves as expected: when activated (blue), it indicates the field is "nullable," and when deactivated (grey), it indicates the field is "not nullable." This update makes the UI more intuitive, providing users with a clearer understanding of the field's state at a glance.