Support Rails 8.1 #949
Merged
Support Rails 8.1 #949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-yagi
force-pushed
the
support_rails81
branch
from
d5cdea8 to
e54ea48
Compare
y-yagi
force-pushed
the
support_rails81
branch
from
e54ea48 to
b63430d
Compare
Collaborator
Author
|
The specs for Rails 8.1 are failed because of jmmastey/rspec-activerecord-expectations#3 |
Alexander-Senko
previously approved these changes
Nov 2, 2025
`ActiveSupport::ExecutionContext.nestable` would be true when `ActiveSupport::TestCase` is loaded. https://github.com/rails/rails/blob/b47cc51b989e09e8a00616bc336c8da7347a90d5/activesupport/lib/active_support/railtie.rb#L68 We load `action_controller/test_case` in Rails console, so this would be true. But, it looks like ``ActiveSupport::ExecutionContext.nestable` only consider to enable on test environment. That cause unexpected behavior. To avoid an error, enforce to disable it. Fixes drapergem#948.
y-yagi
force-pushed
the
support_rails81
branch
2 times, most recently
from
d91f1ec to
65e9004
Compare
Alexander-Senko
previously approved these changes
Nov 4, 2025
y-yagi
force-pushed
the
support_rails81
branch
from
65e9004 to
14d85cc
Compare
Alexander-Senko
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates to support Rails 8.1.
ActiveSupport::ExecutionContext.nestable0bcbbadActiveSupport::ExecutionContext.nestablewould be true whenActiveSupport::TestCaseis loaded. https://github.com/rails/rails/blob/b47cc51b989e09e8a00616bc336c8da7347a90d5/activesupport/lib/active_support/railtie.rb#L68 We loadaction_controller/test_casein Rails console, so this would be true.* But, it looks like ``ActiveSupport::ExecutionContext.nestable
only consider to enable on test environment. That cause unexpected behavior. To avoid an error, enforce to disable it. * To be honest, usingaction_controller/test_case` isn't good idea I think. It's better to have a dummy request class by draper own. But I keep it to simple the PR.To-Dos
References
#948