Improve spec generator template #695
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer RSpec versions requires that you call the first describe block on the RSpec class. I also added the type of the spec and a "pending" message, to make it similar to the default rspec generators. I kept `spec_helper` instead of `rails_helper` because there's no need to load Rails to test the decorator in isolation, since we can test them with POROs.
Author
|
Didn't see #692 before, sorry, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer RSpec versions requires that you call the first describe block on the RSpec class.
I also added the type of the spec and a "pending" message, to make it similar to the default rspec generators.
I kept
spec_helperinstead ofrails_helperbecause there's no need to load Rails to test the decorator in isolation, since we can test them with POROs and/or stubbing methods.