-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] 8316126: [Lilliput/JDK21] Cherry-pick: 8305895: Implementation: JEP 450: Compact Object Headers (Experimental) #74
Conversation
…50: Compact Object Headers (Experimental) Reviewed-by: shade
Reviewed-by: shade
Reviewed-by: shade
…nspection Backport-of: 0568386e062474b1fc31e2e7106db0079ded7d76
|
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/RobustOopDeterminator.java
Show resolved
Hide resolved
jtreg passed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backport the following changes:
8316126: [Lilliput/JDK21] Cherry-pick: 8305895: Implementation: JEP 450: Compact Object Headers (Experimental)
8317954: [Lilliput/JDK21] Make C2 LoadNKlassCompactHeader more robust
8316687: [Lilliput/JDK21] Various cleanups
8319724: [Lilliput] ParallelGC: Forwarded objects found during heap inspection
8316424: [Lilliput/JDK21] ZGC/CDS-related test fixes
These make this pr equivalent to the upstream lilliput pr 13961 https://bugs.openjdk.org/browse/JDK-8305895
Differences are explained below:
Differences caused by the way we port 8139457: Relax alignment of array elements
Here we choose to do the modification in initialize_header, so as to stay consistent across major platforms (x86/aarch64/riscv).
Lilliput21 missed the change to increase itable stuff size (openjdk/jdk@467ccb8). Added back.
Differences in these file are caused by various CDS related changes (8311035, openjdk/jdk@a76bc68, openjdk/jdk@467ccb8)
We don't need them because we don't have 8311035 in 21.
This is caued by missing 8319376 (ParallelGC: Forwarded objects found during heap inspection) in 21. 8319376 will be ported to 21.0.4 later.
But to ensure correctness we still have to apply the fix (and resolve conflict when merging 21.0.4).
It's logically equivalent to pr 13961. No need to change.
All other differences are trivial.