Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] 8316108: [Lilliput/JDK21] Cherry-pick: 8305898: Alternative self-forwarding mechanism #73

Merged
merged 1 commit into from
Jul 5, 2024
Merged

[Backport] 8316108: [Lilliput/JDK21] Cherry-pick: 8305898: Alternative self-forwarding mechanism #73

merged 1 commit into from
Jul 5, 2024

Conversation

linade
Copy link
Collaborator

@linade linade commented Jul 2, 2024 •
edited
Loading

Summary: Backport
8316108: [Lilliput/JDK21] Cherry-pick: 8305898: Alternative self-forwarding mechanism

Differences with upstream pr 17755:

  1. UseAltGCForwarding condition guards the critical parts of the change
  2. The use of displaced_mark_helper is explained in https://github.com/openjdk/jdk/pull/13779/files#r1305779757
  3. A test fix that only matters in 32-bit x86
  4. Cosmetic changes

@rkennke @linade
[Backport] 8316108: [Lilliput/JDK21] Cherry-pick: 8305898: Alternative
b82f956 
self-forwarding mechanism

Summary: Backport
8316108: [Lilliput/JDK21] Cherry-pick: 8305898: Alternative
self-forwarding mechanism

Testing: CICD

Reviewers: mmyxym, weixlu

Issue: dragonwell-project#72
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@linade linade requested review from weixlu and mmyxym July 2, 2024 09:41
mmyxym
mmyxym approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@mmyxym mmyxym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

weixlu
weixlu approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@weixlu weixlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@linade linade merged commit 059b5e1 into dragonwell-project:master Jul 5, 2024
89 of 91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weixlu weixlu weixlu approved these changes

@mmyxym mmyxym mmyxym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@linade @CLAassistant @weixlu @mmyxym @rkennke