Show state change in the revisions view #1310
Open
+114
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caitmich
reviewed
Jan 28, 2025
| @@ -1,5 +1,6 @@ | |||
| [v#.#.#] ([month] [YYYY]) | |||
| - Hera: Add new layout with redesigned navigation | |||
| - Revisions: Show changed state in the revisions view | |||
There was a problem hiding this comment.
Suggested change
| - Revisions: Show changed state in the revisions view | |
| - Revisions: Show state changes in the revisions view |
| def changed_state | ||
| return {} unless @record.respond_to?(:state) | ||
|
|
||
| # Cast the ['state'] attribute as it can be both the state index (0,1,2) or |
There was a problem hiding this comment.
In what case would we get the index instead of the string value?
| @@ -83,7 +83,13 @@ def update | |||
| if @issue.update(issue_params) | |||
| @modified = true | |||
| check_for_edit_conflicts(@issue, updated_at_before_save) | |||
| track_updated(@issue) | |||
|
|
|||
| if @issue.state_previously_changed? && !@issue.text_previously_changed? | |||
There was a problem hiding this comment.
what about moving this block into a helper to reduce clutter in the action?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec
When a record's QA state is updated, a revision (version history entry) is created. However, no changes are displayed since our revision view only shows content changes.
Proposed solution
Display the changed state (if changed) in the revisions view.
Check List