Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DQ_Kinematics.cpp] This PR fixes bug #65, relating to the line_to_line_distance_jacobian method #66

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

DanSJohnson
Copy link
Contributor

Hi @mmmarinho.

As requested, this PR fixes the bug discussed in #65, changing line 647 of DQ_Kinematics.cpp from:

    const MatrixXd Jcrossdual    = Jcross.block(5,8,4,DOFS);

to:

    const MatrixXd Jcrossdual    = Jcross.block(4,0,4,DOFS);

Kind regards,
Daniel.

@mmmarinho mmmarinho self-assigned this Mar 26, 2024
@mmmarinho mmmarinho merged commit 2751d38 into dqrobotics:master Mar 26, 2024
3 of 6 checks passed
@DanSJohnson DanSJohnson deleted the bug-fix-branch branch March 26, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants