Resolve datetime deprecation warnings#2589
Merged
dpkp merged 2 commits intodpkp:masterfrom Apr 16, 2025
emmanuel-ferdman:master
Merged
Resolve datetime deprecation warnings#2589dpkp merged 2 commits intodpkp:masterfrom emmanuel-ferdman:master
dpkp merged 2 commits intodpkp:masterfrom
emmanuel-ferdman:master
Conversation
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Owner
|
Can we modify to keep support for python2.7 ? |
Contributor
Author
|
@dpkp If Python2.7 support is required, I think we could go with something like: import sys
if sys.version_info >= (3, 3):
# Use timezone-aware datetime for Python 3.3+
now = datetime.datetime.fromtimestamp(1629321911, datetime.timezone.utc)
else:
# Fallback to utcfromtimestamp for Python 2.7
now = datetime.datetime.utcfromtimestamp(1629321911)Not the most elegant solution, but it should get the job done while supporting Python 2.7 and future Python versions. What do you think? |
Owner
|
That's great, thanks! |
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
dpkp
approved these changes
Apr 16, 2025
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR fixes the
datetimedeprecation warnings that can be viewed in the CI logs: