Skip to content

fix(filters): prevent shared Filters instance in concurrent requests #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(filters): prevent shared Filters instance in concurrent requests #2367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions flask_appbuilder/api/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1973,9 +1973,12 @@
return order_column, order_direction

def _handle_filters_args(self, rison_args: Dict[str, Any]) -> Filters:
self._filters.clear_filters()
self._filters.rest_add_filters(rison_args.get(API_FILTERS_RIS_KEY, []))
return self._filters.get_joined_filters(self._base_filters)
# self._filters.clear_filters()
filters = self.datamodel.get_filters(

Check warning on line 1977 in flask_appbuilder/api/__init__.py

View check run for this annotation

Codecov / codecov/patch

flask_appbuilder/api/__init__.py#L1977 

Added line #L1977 was not covered by tests
search_columns=self.search_columns, search_filters=self.search_filters
)
filters.rest_add_filters(rison_args.get(API_FILTERS_RIS_KEY, []))
return filters.get_joined_filters(self._base_filters)

Check warning on line 1981 in flask_appbuilder/api/__init__.py

View check run for this annotation

Codecov / codecov/patch

flask_appbuilder/api/__init__.py#L1980-L1981 

Added lines #L1980 - L1981 were not covered by tests

def _description_columns_json(
self, cols: Optional[List[str]] = None
Expand Down
Loading