doc: dovecot.conf is 644 file permission, not 755 #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use INSTALL_DATA instead of INSTALL in doc/Makefile.am to install dovecot.conf with 644 instead of 755 file permission. After the patch, after `./autogen.sh; ./configure`, doc/Makefile shows dovecot.conf is correctly installed with INSTALL_DATA which is `/usr/bin/install -c -m 644` instead of INSTALL which is `/usr/bin/install -c`. More info about INSTALL_DATA see `info make`. Signed-off-by: Xiao Pan <[email protected]>
Contributor
|
Thank you for your pull request, we will look into it. |
Author
|
Related mailing list patch: https://dovecot.org/mailman3/archives/list/[email protected]/thread/T6H3BV5YNV274LTUGP2HJCYURNKPBEXG/. Basically the same thing I wrote here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use INSTALL_DATA instead of INSTALL in doc/Makefile.am to install dovecot.conf with 644 instead of 755 file permission. After the patch, after
./autogen.sh; ./configure, doc/Makefile shows dovecot.conf is correctly installed with INSTALL_DATA which is/usr/bin/install -c -m 644instead of INSTALL which is/usr/bin/install -c. More info about INSTALL_DATA seeinfo make.Not sure mailing list or github pull request is the correct place to submit the patch, so I'll try submit a patch to mailing list later on also.
Edit: I emailed the patch to the mailing list but it is being held for approval because I'm not a list member because my subscription request is pending.
Edit: More detailed writings about the BUG if you prefer:
./autogen.sh; ./configure; make; sudo make installto build and install dovecot, then you can see /usr/local/etc/dovecot/dovecot.conf is installed with 644 file permission before apply my patch.Edit: Another way is to use
$(INSTALL) -m 644instead of$(INSTALL_DATA). This way maybe better for compatibility reason, because I'm not sure if old version of make/autoconf or non-GNU make has INSTALL_DATA or not. (I think maybe make is not very yrelated, maybe autoconf is more related, not sure)