Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make solr-config-9.xml compatible with Solr 9.8.0 #238

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

samangh
Copy link

@samangh samangh commented Mar 28, 2025

Solr 9.8.1 has one breaking change, which this commit fixes. In Solr <lib/> directives have been made into an "opt-in" feature in must be explicitly enabled if desired. Unless this is done (or a better alternative is used), the dovecot provided config will fail. See https://solr.apache.org/guide/solr/latest/upgrade-notes/major-changes-in-solr-9.html#configuration-2

This PR removes the <lib/> directives, and leaves a comment for a use to enable the the appropriate Solr module instead. This is one of the recommended fixes by Solr.

This comment also removes the numVersionBuckets which is obsolete and ignored.

Copy link

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use Solr myself, but while reviewing a community contribution to our docs for this issue, I did come across alternative support via ENV that you might want to also document here?

BTW, the breaking change was introduced in Solr 9.8.0, not 9.8.1 AFAIK.

@samangh
Copy link
Author

samangh commented Apr 2, 2025

@polarathene Thanks for the feedback. I've modified the PR to include setting of the environment variable as another option.

Also changed commit title reflect the correct SOLR version (9.8.0) that introduces this change.

@samangh samangh changed the title Make solr-config-9.xml compatible with Solr 9.8.1 Make solr-config-9.xml compatible with Solr 9.8.0 Apr 2, 2025
Changes:

  * remove `numVersionBuckets` which is obsolete and ignored'
  * remove `<lib ..>`, and instead leave a comment for user to enable modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants