Skip to content

Fix milestone import: use str.strip() instead of non-existing str.trim() #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
santiagorr wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix milestone import: use str.strip() instead of non-existing str.trim() #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39cab2f
Get issues ID from item.status instead of non-existing item.statusCat…
Nov 17, 2021
4a1fe91
Fix milestone import: use str.strip() instead of non-existing str.trim()
Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def _projectFor(self, item):

def _append_item_to_project(self, item):
# todo assignee
closed = str(item.statusCategory.get('id')) == self.doneStatusCategoryId
closed = str(item.status.get('id')) == self.doneStatusCategoryId
closed_at = ''
if closed:
try:
Expand Down Expand Up @@ -110,7 +110,7 @@ def _add_milestone(self, item):
try:
self._project['Milestones'][item.fixVersion.text] += 1
# this prop will be deleted later:
self._project['Issues'][-1]['milestone_name'] = item.fixVersion.text.trim()
self._project['Issues'][-1]['milestone_name'] = item.fixVersion.text.strip()
except AttributeError:
pass

Expand Down