Refactor/summary task status scatter#1078
Closed
kacieje wants to merge 2 commits intodoubtfire-lms:9.xfrom
Closed
Conversation
Member
|
Hi @kacieje Thanks for your contribution. Although this component isn’t currently used, we’d prefer to rebuild it rather than remove it. The goal is to replace it with a Normalized vertical bar chart, where:
This will give staff a clear overview of task completion and how it changes throughout the semester. I've started the refactor in these PRs, but there's still work to do: I’m currently focused on other features, so this is up for grabs if anyone wants to pick it up and continue. Notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thoth-tech/doubfire-web:doc/readme migration progress update thoth-tech#432
Description
This PR removes an unused coffee component summary-task-status-scatter. No references to this visualisation could be found for initialisation and it could not be triggered in testing.
Type of change
How Has This Been Tested?
Triggering of the component was tested by searching through the code base for references to the component (summary-task-status-scatter and summaryTaskStatusScatter). The component itself (summary-task-status-scatter.coffee) and the visualations template (visualisation.tpl.html were located but no triggers for actual use. Once the changes in this PR were applied, various visualisations were tested and no changes to their functionality were identified.
Testing Checklist:
Checklist: