-
Notifications
You must be signed in to change notification settings - Fork 1
[L] Add membership page #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pc-11
wants to merge
27
commits into
doubleunion:app-layout
Choose a base branch
from
pc-11:app-layout
base: app-layout
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added 'dark/primary' as a new choice for Buttons (borders don't appear to work) - added membership page - not working: - stripe - form POSTs - relative URLs with user_id - responsive sizes for header + body
- email, stripe-dropdown, table-of-contents, heading
core heading component
`linkable` to Heading
Major Changes: 1) Added supabase fetching to members/profile 2) Added auth-checking to root Minor Changes: 1) Fixed styling for navbar (clobbered by <a> styling in app.css) 2) Fixed navbar indicator which only showed the 'home' route, now highlights current route
Constructs a profile update to the Supabase table correctly, but does not work E2E w/o the auth flow working first
- Needed 7.9.1 for access to v8_middleware future flag - Added three routes (/signin, /logout/, /auth-callback)
Seems to work, but sometimes you have to sign in twice: - The first sign in after sign out seems to have an AuthApiError??
fixed profile minor: removed google oauth button as a separate class
Minor: Replacing extraneous spacing on each div
internal navigation
Breaking: - Changed ui-toolkit Table, Input to accept overrides - Changed showToast signature to use props Medium: - Added the fake data + table UI for members.home - Added the profile page for individual members Minor: - Added h4 sizing - UI Tweaks for table
Nits with logging left in
Major: - added role-guard clauses to application home which was broken in the last commit - added role-guard clauses to application view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
app.cssdark/primaryin the
buttons.tsxcomponentTODO:
user_idin some capacity, or injecting that in the route itselfScreenshots