Skip to content

refactor(auth): Replace module-level lint suppression with field-level attributes and add zeroization tests #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doublegate merged 3 commits into from
Jan 10, 2026
Merged

refactor(auth): Replace module-level lint suppression with field-level attributes and add zeroization tests #60

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7065978
Initial plan
Copilot Jan 10, 2026
5e7be54
refactor(auth): Move lint suppression from module-level to field-leve…
Copilot Jan 10, 2026
b881ba7
test(auth): Add comprehensive zeroization test coverage for security-…
Copilot Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/rustirc-core/src/auth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
//! implementing PLAIN, EXTERNAL, and SCRAM-SHA-256 mechanisms as specified
//! in Phase 2 requirements.

#![allow(unused_assignments)] // Zeroize derive generates field assignments for security

use anyhow::Result;
use base64::{engine::general_purpose::STANDARD as BASE64, Engine as _};
use std::collections::HashMap;
Expand All @@ -28,16 +26,18 @@ pub enum AuthState {
/// SASL credentials with secure password storage
#[derive(Debug, Clone, Zeroize, ZeroizeOnDrop)]
pub struct SaslCredentials {
#[allow(unused_assignments)] // Zeroize derive generates field assignments for security
pub username: String,
#[zeroize(skip)]
#[allow(unused_assignments)] // Zeroize derive generates field assignments for security
pub password: SecureString,
#[allow(unused_assignments)] // Zeroize derive generates field assignments for security
pub authzid: Option<String>,
}

/// Secure string that automatically zeroes memory on drop
#[derive(Clone, Zeroize, ZeroizeOnDrop)]
pub struct SecureString {
#[zeroize(skip)]
#[allow(unused_assignments)] // Zeroize derive generates field assignments for security
inner: Vec<u8>,
}

Expand Down