Skip to content

fix: removing prompt from text output in outlines serve #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Martins6
Copy link

@Martins6 Martins6 commented Apr 8, 2025

PR to solve #1525 .

@Martins6
Copy link
Author

Martins6 commented Apr 18, 2025

It says that the tests are failing but I don't see how they are connected at all. It seems it is a bug?

This is the function failing:

@pytest.mark.parametrize("pattern", REGEX_PATTERNS)
@pytest.mark.parametrize("model_fixture", ALL_MODEL_FIXTURES)
def test_generate_regex(request, model_fixture, pattern):
    model = request.getfixturevalue(model_fixture)
    generator = generate.regex(model, pattern)
    res = generator(**get_inputs(model_fixture), max_tokens=20)
    assert re.fullmatch(pattern, res) is not None, res

I don't see how they are connected to serve module or serve main function. So...I'm not sure what to do next 😅

cc: @rlouf @cpfiffer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant