Skip to content

Create the Application class #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2025

Conversation

RobinPicard
Copy link
Contributor

@RobinPicard RobinPicard commented Feb 27, 2025

Addresses issue #1346

The class will actually be called Application instead of Outline, but it will otherwise implement the interface suggested in the linked issue. We additionally remove the functions module.

@RobinPicard RobinPicard linked an issue Feb 27, 2025 that may be closed by this pull request
@RobinPicard RobinPicard self-assigned this Feb 27, 2025
@RobinPicard RobinPicard added this to the 1.0 milestone Feb 27, 2025
@RobinPicard RobinPicard requested a review from rlouf February 27, 2025 13:22
template: Union[Template, Callable]
output_type: Any

def __post_init__(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a with_backend method that allows a user to change how a model is going to be run? And lazily load the model and compile lazily so this does not happen when the Macro is instantiated, only when it is used?

The idea is to eventually have people only pass a string with the model name.

@rlouf
Copy link
Member

rlouf commented Feb 27, 2025

Supersedes #1364

@rlouf
Copy link
Member

rlouf commented Mar 9, 2025

Wondering if we should simply call it Application

@RobinPicard
Copy link
Contributor Author

RobinPicard commented Mar 11, 2025

I prefer Application. My issue with Macro is that it sounds too much like it's creating a filled-out template that still needs to be run. Is there a risk we will want to use the word "Application" for something else in the future though?

@rlouf
Copy link
Member

rlouf commented Mar 11, 2025

Let's use Application for now

@rlouf rlouf changed the title Create the Macro class Create the Application class Mar 11, 2025
@rlouf
Copy link
Member

rlouf commented Mar 15, 2025

We had an offline discussion where we decided to pass the model as an argument when calling the application. This makes Application object more re-usable.

@RobinPicard RobinPicard force-pushed the replace_functions_by_macro branch from 43b2d74 to ef625f9 Compare March 16, 2025 22:14
@RobinPicard RobinPicard requested a review from rlouf March 16, 2025 22:16
@RobinPicard RobinPicard merged commit a872758 into dottxt-ai:v1.0 Mar 16, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Applications
2 participants