Reproducible Python virtual environment using uv and nix
#1387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 22, 2025
Open
yvan-sraka
force-pushed
the
reproducibility-with-nix-and-uv
branch
2 times, most recently
from
d5c0359 to
91ca04e
Compare
yvan-sraka
force-pushed
the
reproducibility-with-nix-and-uv
branch
from
91ca04e to
a4442a3
Compare
This was referenced Jan 31, 2025
rlouf
approved these changes
Feb 12, 2025
|
@yvan-sraka I see this was marked as a draft. Is it in a mergeable state? |
You can merge it! I would have preferred to test it by making sure the tests pass first. I guess fixing the tests may require bumping dependencies, but that could be done in another PR. Also, I'm not 100% sure the Nix expression isn't missing anything since the tests didn't pass... The sibling PR in |
|
Why was pre-commit added as a runtime dependency? This seems wrong. |
|
Ah, this was also mentioned in #1465 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft aimed at producing a reproducible Python virtual environment.
uvseems like the right tool for this because it has a lock file mechanism (but we could alternatively usepoetry), andnixwould be my preferred choice for managing system dependencies (I’m not aware of many alternatives for pinning system dependencies, apart from possibly using a container with a pinned version of Alpine Linux?)This is still a draft, the
shell.nixis currently too convoluted (and ultimately I would like to rather rely on uv2nix), and the goal of this PR is to enable the use of this environment in GitHub Action jobs! Using this setup in CI would help avoid non-reproducible issues, such as this one.n.b. that VLLM is currently broken on NixOS, debugging its derivation might be necessary at some point:
nix-build /nix/var/nix/profiles/per-user/root/channels/nixos/ --run-env -A python3Packages.vllm