Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ArrayList from FrameworkElement with List<TemplateKey> #10700

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

h3xds1nz
Copy link
Member

@h3xds1nz h3xds1nz commented Apr 3, 2025

Description

Replaces ArrayList with List<TemplateKey> to increase type safety and promote strongly-typed code. Most of the perf benefits beyond t0 were now erased in post .NET 9 as the ArrayList methods are usually successfully de-abstracted but that doesn't really matter as its still a benefit to use a generic collection type instead e.g. to bypass cast checks.

Customer Impact

Cleaner codebase for developers.

Regression

No.

Testing

Local build.

Risk

Low, just a type swap on private collection.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested review from a team as code owners April 3, 2025 17:52
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Apr 3, 2025
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 10.94648%. Comparing base (2ded801) to head (67b3c5f).

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10700         +/-   ##
===================================================
- Coverage   10.95887%   10.94648%   -0.01239%     
===================================================
  Files           3310        3310                 
  Lines         664667      664661          -6     
  Branches       74667       74666          -1     
===================================================
- Hits           72840       72757         -83     
- Misses        590685      590770         +85     
+ Partials        1142        1134          -8     
Flag Coverage Δ
Debug 10.94648% <0.00000%> (-0.01239%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@siagupta0202 siagupta0202 self-assigned this Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants