Avoid unnecessary delegate/closure allocations in UIElementAutomationPeer #10691
+99
−107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10676
Description
Avoids unnecessary delegate/closure allocations in
UIElementAutomationPeer
by passing the argument via ref instead for this recursive iterator function, allowing to use a static lambda instead.I've also used the instance over static factory method for
CreateAutomationPeer
to avoid the unnecessary null check that we've performed right before calling this method, further improving perf on this hot path.Since the implementation is same for
UIElement3DAutomationPeer
, I've shared it.Customer Impact
See #10676 for impact of this change.
Regression
No.
Testing
Local build, verifying that peers are still created.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow