Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid obsoletion warning suppression in ActiveXHost #10689

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

h3xds1nz
Copy link
Member

@h3xds1nz h3xds1nz commented Apr 1, 2025

Description

Avoids warning suppression for ApartmentState property by using the newer method instead. In the retrieval (get) context, checking for STA has no behavioral difference between those two, hence no reason to NOT use it.

Also, this is the only place in WPF where the swap to the method hasn't been done yet.

Customer Impact

Cleaner codebase for developers, not using BCL obsoleted methods.

Regression

No.

Testing

Local build.

Risk

Low.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested review from a team as code owners April 1, 2025 14:50
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Apr 1, 2025
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 11.25335%. Comparing base (4aff730) to head (5a92c44).
Report is 5 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10689         +/-   ##
===================================================
- Coverage   11.28308%   11.25335%   -0.02974%     
===================================================
  Files           3353        3353                 
  Lines         668062      668041         -21     
  Branches       74980       74980                 
===================================================
- Hits           75378       75177        -201     
- Misses        591433      591616        +183     
+ Partials        1251        1248          -3     
Flag Coverage Δ
Debug 11.25335% <0.00000%> (-0.02974%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@siagupta0202 siagupta0202 self-assigned this Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants