[Fluent] Fixes multiple issues in DatePicker style #10688
+412
−290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (5)
- src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/Variables.xaml: Language not supported
- src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/DatePicker.xaml: Language not supported
- src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.Dark.xaml: Language not supported
- src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.HC.xaml: Language not supported
- src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.Light.xaml: Language not supported
dotnet-policy-service
bot
added
the
PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10688 +/- ##
===================================================
- Coverage 12.71897% 12.67103% -0.04795%
===================================================
Files 3316 3316
Lines 665321 665321
Branches 74667 74667
===================================================
- Hits 84622 84303 -319
- Misses 578480 578813 +333
+ Partials 2219 2205 -14
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
siagupta0202
reviewed
Apr 1, 2025
src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/DatePicker.xaml
Outdated
Show resolved
Hide resolved
dipeshmsft
force-pushed
the
fluent/style-fix/datepicker-2
branch
from
a55ef45 to
2ddd166
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10519
Description
Fixes multiple issues in DatePicker style including the ones mentioned in the above issue. Few of these include :
Customer Impact
Makes it easier for developers to adopt fluent theme.
Regression
N/A
Testing
Local app testing.
Risk
Low - Medium. If developers have adopted Fluent in .NET 9 they would need to make changes in their applications, to incorporate the new behavior. For devs moving from Aero2 to Fluent will see less disruptions in the style.
Microsoft Reviewers: Open in CodeFlow