Avoid boxing booleans and allocations in UncommonField<bool> #10681
+37
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
PR
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10681 +/- ##
===================================================
+ Coverage 11.25210% 11.27492% +0.02281%
===================================================
Files 3353 3353
Lines 668062 668058 -4
Branches 74980 74980
===================================================
+ Hits 75171 75323 +152
+ Misses 591642 591480 -162
- Partials 1249 1255 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10677
Fixes #4114
Description
Even though
UncommonFielditself is generic, the underlying value storage (EffectiveValues) is not, therefore values saved in uncommon field end up being boxed same wayDependencyPropertyvalues are.A common case is storing a
boolean(mostlytrue), which we can easily special-case using ourBooleanBoxes.While I could fix
Unsetvalues for value types, this wasn't originally done so that would be a behavioral change (though it would probably help in some cases to free up some memory).Customer Impact
See #10677 for impact of this change.
Regression
Depends how you look at it, given the history. But it was boxing in the original, so I guess not.
Testing
Local build, verifying functionality accross different scenarios (
GridView,HiearchicalVirtualizationviaTreeView/VirtualizingStackPanel, etc.)Risk
Low, this just adds a generic path for
boolthat is otherwise eliminated.Microsoft Reviewers: Open in CodeFlow