Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dead code in ElementUtil, make class static #10680

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

h3xds1nz
Copy link
Member

@h3xds1nz h3xds1nz commented Mar 30, 2025

Description

Removes dead code inside ElementUtil which is everything but 1 method. Also makes the class static as it is nothing more but a static method holder that has no instance (previously prevented using private constructor).

Lastly a format has been done since I removed most of the code anyways.

Customer Impact

Cleaner codebase for developers.

Regression

No.

Testing

Local build.

Risk

None, just unused dead code.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested review from a team as code owners March 30, 2025 19:03
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Mar 30, 2025
Copy link

codecov bot commented Mar 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 11.37781%. Comparing base (2a8258a) to head (beb37d9).

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10680         +/-   ##
===================================================
+ Coverage   11.25210%   11.37781%   +0.12570%     
===================================================
  Files           3353        3353                 
  Lines         668062      667958        -104     
  Branches       74980       74966         -14     
===================================================
+ Hits           75171       75999        +828     
+ Misses        591642      590711        -931     
+ Partials        1249        1248          -1     
Flag Coverage Δ
Debug 11.37781% <0.00000%> (+0.12570%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant