-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ShaperBuffers/OpenTypeLayoutCache and NetFX v3.X dead code #10664
Open
h3xds1nz
wants to merge
17
commits into
dotnet:main
Choose a base branch
from
h3xds1nz:remove-opentype-stuff
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3
−5,469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10664 +/- ##
===================================================
- Coverage 11.27425% 11.23706% -0.03720%
===================================================
Files 3353 3351 -2
Lines 668062 666847 -1215
Branches 74980 74821 -159
===================================================
- Hits 75319 74934 -385
+ Misses 591489 590667 -822
+ Partials 1254 1246 -8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Community Contribution
A label for all community Contributions
PR
metadata: Label to tag PRs, to facilitate with triage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
ShaperBuffers
/ShapingOptions
/ShaperFeaturesList
classes that are pure dead code. Actually unused sincenetfx4
after swapping inPresentationCore
from the old engine (IShaper
/IShapingEngine
) andPresentationFontCache
.CachedFontFace
/CachedFontFamily
/FontCacheLogic
/CachedCompositeFamily
/IPCCacheManager
are not included in compilation at all but they were in the repo for no reason, really, since we useDWrite
now.FontCacheConstants
were included in the compilation but the class is just full of constants.FeatureTags
areOpenType
feature tags that are publicly known and can be retrieved anytime.Code removed in
OpenTypeLayout
/OpenTypeCommon
cascades by removing one uncalled method after another;OpenTypeLayoutCache
is only used by one of these uncalled methods.Customer Impact
Cleaner codebase for developers.
Regression
No.
Testing
Local build, app run with typography, opentype fonts stuff.
Risk
Low as it is a lot to remove but all is unused dead code.
Microsoft Reviewers: Open in CodeFlow