Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ShaperBuffers/OpenTypeLayoutCache and NetFX v3.X dead code #10664

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

h3xds1nz
Copy link
Member

@h3xds1nz h3xds1nz commented Mar 28, 2025

Description

Removes ShaperBuffers/ShapingOptions/ShaperFeaturesList classes that are pure dead code. Actually unused since netfx4 after swapping in PresentationCore from the old engine (IShaper/IShapingEngine) and PresentationFontCache.

CachedFontFace / CachedFontFamily / FontCacheLogic / CachedCompositeFamily / IPCCacheManager are not included in compilation at all but they were in the repo for no reason, really, since we use DWrite now.

FontCacheConstants were included in the compilation but the class is just full of constants.

FeatureTags are OpenType feature tags that are publicly known and can be retrieved anytime.

Code removed in OpenTypeLayout / OpenTypeCommon cascades by removing one uncalled method after another; OpenTypeLayoutCache is only used by one of these uncalled methods.

Customer Impact

Cleaner codebase for developers.

Regression

No.

Testing

Local build, app run with typography, opentype fonts stuff.

Risk

Low as it is a lot to remove but all is unused dead code.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested review from a team as code owners March 28, 2025 09:27
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Mar 28, 2025
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.23706%. Comparing base (0d19d68) to head (b1d5aa5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10664         +/-   ##
===================================================
- Coverage   11.27425%   11.23706%   -0.03720%     
===================================================
  Files           3353        3351          -2     
  Lines         668062      666847       -1215     
  Branches       74980       74821        -159     
===================================================
- Hits           75319       74934        -385     
+ Misses        591489      590667        -822     
+ Partials        1254        1246          -8     
Flag Coverage Δ
Debug 11.23706% <ø> (-0.03720%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant