-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cleanup] Use named arguments in System.Xaml #10061
Open
ThomasGoulet73
wants to merge
1
commit into
dotnet:main
Choose a base branch
from
ThomasGoulet73:cleanup-use-named-arguments-in-System.Xaml
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Cleanup] Use named arguments in System.Xaml #10061
ThomasGoulet73
wants to merge
1
commit into
dotnet:main
from
ThomasGoulet73:cleanup-use-named-arguments-in-System.Xaml
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
November 13, 2024 00:21
dotnet-policy-service
bot
added
PR
metadata: Label to tag PRs, to facilitate with triage
Community Contribution
A label for all community Contributions
labels
Nov 13, 2024
lindexi
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ThomasGoulet73
changed the title
Cleanup: Use named arguments in System.Xaml
[Cleanup] Use named arguments in System.Xaml
Dec 17, 2024
himgoyalmicro
previously approved these changes
Dec 18, 2024
LGTM. We have included it in test pass, and I will have the result soon. |
Contributes to dotnet#10018
ThomasGoulet73
force-pushed
the
cleanup-use-named-arguments-in-System.Xaml
branch
from
December 20, 2024 05:21
ebae0b1
to
f9066f0
Compare
Done. |
harshit7962
added
Status:Completed
and removed
Status:InProgress
Status:Proposed
labels
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Community Contribution
A label for all community Contributions
Included in test pass
PR
metadata: Label to tag PRs, to facilitate with triage
Status:Completed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #10018
Description
I replaced comments specifying an argument name with named arguments, which were introduced in C# 7. This improves readability and maintainability.
Note: The compiled IL is identical.
Customer Impact
None.
Regression
No.
Testing
Local build + validated IL.
Risk
Low to none.
Microsoft Reviewers: Open in CodeFlow