Cleanup: Use named arguments in System.Xaml. (#10061)

ThomasGoulet73 · web-flow · commit e9bc60b805e0 · 2024-12-30T10:10:25.000+05:30
Contributes to #10018
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Context/ObjectWriterContext.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Context/ObjectWriterContext.cs
@@ -168,7 +168,7 @@ internal XamlType ServiceProvider_ResolveXamlType(string qName)
 
         internal AmbientPropertyValue ServiceProvider_GetFirstAmbientValue(IEnumerable<XamlType> ceilingTypes, XamlMember[] properties)
         {
-            List<AmbientPropertyValue> valueList = FindAmbientValues(ceilingTypes, /*searchLiveStackOnly*/false, /*types*/null, properties, true);
+            List<AmbientPropertyValue> valueList = FindAmbientValues(ceilingTypes, searchLiveStackOnly: false, types: null, properties, true);
             return (valueList.Count == 0) ? null : valueList[0];
         }
 
@@ -180,7 +180,7 @@ internal object ServiceProvider_GetFirstAmbientValue(XamlType[] types)
 
         internal IEnumerable<AmbientPropertyValue> ServiceProvider_GetAllAmbientValues(IEnumerable<XamlType> ceilingTypes, XamlMember[] properties)
         {
-            List<AmbientPropertyValue> valueList = FindAmbientValues(ceilingTypes, /*searchLiveStackOnly*/false, /*types*/null, properties, /*stopAfterFirst*/ false);
+            List<AmbientPropertyValue> valueList = FindAmbientValues(ceilingTypes, searchLiveStackOnly: false, types: null, properties, stopAfterFirst: false);
             return valueList;
         }
 
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/InfosetObjects/XamlObjectWriter.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/InfosetObjects/XamlObjectWriter.cs
@@ -129,7 +129,7 @@ private XamlRuntime CreateRuntime(XamlObjectWriterSettings settings, XamlSchemaC
             }
             if (result is null)
             {
-                result = new ClrObjectRuntime(runtimeSettings, true /*isWriter*/);
+                result = new ClrObjectRuntime(runtimeSettings, isWriter: true);
             }
             result.LineInfo = this;
             return result;
@@ -604,7 +604,7 @@ public override void WriteStartMember(XamlMember property)
 
             // Duplicate Property Setting Check.
             //
-            Logic_DuplicatePropertyCheck(_context, property, false /*onParent*/);
+            Logic_DuplicatePropertyCheck(_context, property, onParent: false);
 
             // If we haven't created the object yet then consider creating it now.
             // We need an object instance to set property values on.
@@ -1529,7 +1529,7 @@ private void Logic_ApplyCurrentPreconstructionPropertyValues(ObjectWriterContext
                     }
                     else
                     {
-                        Logic_ApplyPropertyValue(ctx, prop, value, false /*onParent*/);
+                        Logic_ApplyPropertyValue(ctx, prop, value, onParent: false);
                     }
                 }
             }
@@ -2009,7 +2009,7 @@ private void Logic_DoAssignmentToParentProperty(ObjectWriterContext ctx)
 
                         if (!ctx.CurrentIsObjectFromMember)
                         {
-                            Logic_ApplyPropertyValue(ctx, parentProperty, value, true /*onParent*/);
+                            Logic_ApplyPropertyValue(ctx, parentProperty, value, onParent: true);
 
                             // registered a named object
                             if (parentProperty == parentType.GetAliasedProperty(XamlLanguage.Name))
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/InfosetObjects/XamlTextReader.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/InfosetObjects/XamlTextReader.cs
@@ -111,7 +111,7 @@ private void Initialize(XmlReader givenXmlReader, XamlSchemaContext schemaContex
             _endOfStreamNode = new InternalNode(InternalNodeType.EndOfStream);
 
             _context = (XamlParserContext)XamlContext.CreateContext(UsageMode.Parser, schemaContext,
-                                                            _mergedSettings.LocalAssembly, false /*ignoreCanConvert*/);
+                                                            _mergedSettings.LocalAssembly, ignoreCanConvert: false);
 
             XamlScanner xamlScanner = new XamlScanner(_context, myXmlReader, _mergedSettings);
             XamlPullParser parser = new XamlPullParser(_context, xamlScanner, _mergedSettings);
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Parser/MeScanner.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Parser/MeScanner.cs
@@ -321,14 +321,14 @@ private void ResolvePropertyName(string longName)
 
             if (propName.IsDotted)
             {
-                prop = _context.GetDottedProperty(tagType, tagNamespace, propName, false /*tagIsRoot*/);
+                prop = _context.GetDottedProperty(tagType, tagNamespace, propName, tagIsRoot: false);
             }
             // Regular property p
             else
             {
                 string ns = _context.GetAttributeNamespace(propName, Namespace);
                 declaringType = _context.CurrentType;
-                prop = _context.GetNoDotAttributeProperty(declaringType, propName, Namespace, ns, false /*tagIsRoot*/);
+                prop = _context.GetNoDotAttributeProperty(declaringType, propName, Namespace, ns, tagIsRoot: false);
             }
             _tokenProperty = prop;
         }
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Parser/XamlAttribute.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Parser/XamlAttribute.cs
@@ -152,7 +152,7 @@ private XamlMember GetXamlAttributeProperty(XamlParserContext context, XamlPrope
                 if (propName.IsDotted)
                 {
                     XamlType attachedOwnerType = new XamlType(string.Empty, propName.OwnerName, null, context.SchemaContext);
-                    unknownProperty = new XamlMember(propName.Name, attachedOwnerType, true /*isAttachable*/);
+                    unknownProperty = new XamlMember(propName.Name, attachedOwnerType, isAttachable: true);
                 }
                 else
                 {
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Runtime/DynamicMethodRuntime.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Runtime/DynamicMethodRuntime.cs
@@ -122,15 +122,15 @@ private Dictionary<Type, DelegateCreator> DelegateCreators
 
         internal DynamicMethodRuntime(XamlRuntimeSettings settings, XamlSchemaContext schemaContext,
             XamlAccessLevel accessLevel)
-            : base(settings, true /*isWriter*/)
+            : base(settings, isWriter: true)
         {
             Debug.Assert(schemaContext is not null);
             Debug.Assert(accessLevel is not null);
             _schemaContext = schemaContext;
             _localAssembly = Assembly.Load(accessLevel.AssemblyAccessToAssemblyName);
             if (accessLevel.PrivateAccessToTypeName is not null)
             {
-                _localType = _localAssembly.GetType(accessLevel.PrivateAccessToTypeName, true /*throwOnError*/);
+                _localType = _localAssembly.GetType(accessLevel.PrivateAccessToTypeName, throwOnError: true);
             }
         }
 
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Runtime/PartialTrustTolerantRuntime.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Runtime/PartialTrustTolerantRuntime.cs
@@ -37,7 +37,7 @@ class PartialTrustTolerantRuntime : XamlRuntime
 
         public PartialTrustTolerantRuntime(XamlRuntimeSettings runtimeSettings, XamlAccessLevel accessLevel, XamlSchemaContext schemaContext)
         {
-            _transparentRuntime = new ClrObjectRuntime(runtimeSettings, true /*isWriter*/);
+            _transparentRuntime = new ClrObjectRuntime(runtimeSettings, isWriter: true);
             _accessLevel = accessLevel;
             _schemaContext = schemaContext;
         }
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/CollectionReflector.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/CollectionReflector.cs
@@ -65,11 +65,11 @@ internal static XamlCollectionKind LookupCollectionKind(Type type, out MethodInf
             }
 
             // If the type doesn't match any of the interfaces, check for Add methods
-            if (TryGetDictionaryAdder(type, false /*mayBeIDictionary*/, out addMethod))
+            if (TryGetDictionaryAdder(type, mayBeIDictionary: false, out addMethod))
             {
                 return XamlCollectionKind.Dictionary;
             }
-            if (TryGetCollectionAdder(type, false /*mayBeICollection*/, out addMethod))
+            if (TryGetCollectionAdder(type, mayBeICollection: false, out addMethod))
             {
                 return XamlCollectionKind.Collection;
             }
@@ -83,14 +83,14 @@ internal static MethodInfo LookupAddMethod(Type type, XamlCollectionKind collect
             switch (collectionKind)
             {
                 case XamlCollectionKind.Collection:
-                    bool isCollection = TryGetCollectionAdder(type, true /*mayBeICollection*/, out result);
+                    bool isCollection = TryGetCollectionAdder(type, mayBeICollection: true, out result);
                     if (isCollection && result is null)
                     {
                         throw new XamlSchemaException(SR.Format(SR.AmbiguousCollectionItemType, type));
                     }
                     break;
                 case XamlCollectionKind.Dictionary:
-                    bool isDictionary = TryGetDictionaryAdder(type, true /*mayBeIDictionary*/, out result);
+                    bool isDictionary = TryGetDictionaryAdder(type, mayBeIDictionary: true, out result);
                     if (isDictionary && result is null)
                     {
                         throw new XamlSchemaException(SR.Format(SR.AmbiguousDictionaryItemType, type));
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/Reflector.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/Reflector.cs
@@ -66,7 +66,7 @@ public string GetAttributeString(Type attributeType, out bool checkedInherited)
                 // Passes inherit=true for reasons explained in comment on XamlType.TryGetAttributeString
                 checkedInherited = true;
 
-                object[] attributes = CustomAttributeProvider.GetCustomAttributes(attributeType, true /*inherit*/);
+                object[] attributes = CustomAttributeProvider.GetCustomAttributes(attributeType, inherit: true);
                 if (attributes.Length == 0)
                 {
                     return null;
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/TypeReflector.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/TypeReflector.cs
@@ -754,23 +754,23 @@ private List<MethodInfo> LookupStaticAdders(string name)
             string adderName = KnownStrings.Add + name + KnownStrings.Handler;
             MemberInfo[] adders = UnderlyingType.GetMember(adderName, MemberTypes.Method, AttachableProperties_BF);
             List<MethodInfo> preferredAdders, otherAdders;
-            PrioritizeAccessors(adders, true /*isEvent*/, false /*isGetter*/, out preferredAdders, out otherAdders);
+            PrioritizeAccessors(adders, isEvent: true, isGetter: false, out preferredAdders, out otherAdders);
             return preferredAdders ?? otherAdders;
         }
 
         private List<MethodInfo> LookupStaticGetters(string name)
         {
             MemberInfo[] getters = UnderlyingType.GetMember(KnownStrings.Get + name, MemberTypes.Method, AttachableProperties_BF);
             List<MethodInfo> preferredGetters, otherGetters;
-            PrioritizeAccessors(getters, false /*isEvent*/, true /*isGetter*/, out preferredGetters, out otherGetters);
+            PrioritizeAccessors(getters, isEvent: false, isGetter: true, out preferredGetters, out otherGetters);
             return preferredGetters ?? otherGetters;
         }
 
         private List<MethodInfo> LookupStaticSetters(string name)
         {
             MemberInfo[] setters = UnderlyingType.GetMember(KnownStrings.Set + name, MemberTypes.Method, AttachableProperties_BF);
             List<MethodInfo> preferredSetters, otherSetters;
-            PrioritizeAccessors(setters, false /*isEvent*/, false /*isGetter*/, out preferredSetters, out otherSetters);
+            PrioritizeAccessors(setters, isEvent: false, isGetter: false, out preferredSetters, out otherSetters);
             return preferredSetters ?? otherSetters;
         }
 
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/XmlNamespace.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/XmlNamespace.cs
@@ -75,7 +75,7 @@ public override XamlProperty GetDirectiveProperty(string name)
             if (directive == null)
             {
                 directive = new UnknownProperty(name,
-                                                null, /*declaringType - xml directives don't have one. */
+                                                declaringType: null, /* xml directives don't have a declaring type. */
                                                 XmlDirectives.Uri);
             }
             return directive;
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/XamlMember.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/XamlMember.cs
@@ -45,7 +45,7 @@ public XamlMember(PropertyInfo propertyInfo, XamlSchemaContext schemaContext)
         }
 
         public XamlMember(PropertyInfo propertyInfo, XamlSchemaContext schemaContext, XamlMemberInvoker invoker)
-            : this(propertyInfo, schemaContext, invoker, new MemberReflector(false /*isEvent*/))
+            : this(propertyInfo, schemaContext, invoker, new MemberReflector(isEvent: false))
         {
         }
 
@@ -68,7 +68,7 @@ public XamlMember(EventInfo eventInfo, XamlSchemaContext schemaContext)
         }
 
         public XamlMember(EventInfo eventInfo, XamlSchemaContext schemaContext, XamlMemberInvoker invoker)
-            :this(eventInfo, schemaContext, invoker, new MemberReflector(true /*isEvent*/))
+            :this(eventInfo, schemaContext, invoker, new MemberReflector(isEvent: true))
         {
         }
 
@@ -93,7 +93,7 @@ public XamlMember(string attachablePropertyName, MethodInfo getter, MethodInfo s
 
         public XamlMember(string attachablePropertyName, MethodInfo getter, MethodInfo setter,
             XamlSchemaContext schemaContext, XamlMemberInvoker invoker)
-            :this(attachablePropertyName, getter, setter, schemaContext, invoker, new MemberReflector(getter, setter, false /*isEvent*/))
+            :this(attachablePropertyName, getter, setter, schemaContext, invoker, new MemberReflector(getter, setter, isEvent: false))
         {
         }
 
@@ -126,7 +126,7 @@ public XamlMember(string attachableEventName, MethodInfo adder, XamlSchemaContex
 
         public XamlMember(string attachableEventName, MethodInfo adder, XamlSchemaContext schemaContext,
             XamlMemberInvoker invoker)
-            : this(attachableEventName, adder, schemaContext, invoker, new MemberReflector(null, adder, true /*isEvent*/))
+            : this(attachableEventName, adder, schemaContext, invoker, new MemberReflector(null, adder, isEvent: true))
         {
         }
 
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/XamlObjectReader.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/XamlObjectReader.cs
@@ -529,7 +529,7 @@ public static MemberMarkupInfo ForProperty(
 
             static MemberMarkupInfo ForSequence(object source, XamlMember property, SerializerContext context, bool isAttachable)
             {
-                var itemsInfo = ForSequenceItems(source, isAttachable ? null : property, property.Type, context, false /*allowReadOnly*/);
+                var itemsInfo = ForSequenceItems(source, isAttachable ? null : property, property.Type, context, allowReadOnly: false);
                 if (itemsInfo is not null && itemsInfo.Children.Count != 0)
                 {
                     return new MemberMarkupInfo
@@ -1197,7 +1197,7 @@ void AddItemsProperty(object value, SerializerContext context, XamlType xamlType
                 }
                 else if (xamlType.IsCollection)
                 {
-                    propertyInfo = MemberMarkupInfo.ForSequenceItems(value, null, xamlType, context, true /*allowReadOnly*/);
+                    propertyInfo = MemberMarkupInfo.ForSequenceItems(value, null, xamlType, context, allowReadOnly: true);
                 }
 
                 if (propertyInfo is not null && propertyInfo.Children.Count != 0)
@@ -2485,7 +2485,7 @@ public SerializerContext(XamlSchemaContext schemaContext, XamlObjectReaderSettin
                 prefixToNamespaceMap = new Dictionary<string, string>();
                 ReferenceTable = new ReferenceTable(null);
                 this.schemaContext = schemaContext;
-                runtime = new ClrObjectRuntime(null, false /*isWriter*/);
+                runtime = new ClrObjectRuntime(null, isWriter: false);
                 this.settings = settings;
             }
 
diff --git a/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/XamlType.cs b/src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/XamlType.cs
@@ -334,7 +334,7 @@ public XamlMember GetMember(string name)
             XamlMember result;
             if (!_reflector.Members.TryGetValue(name, out result) && !_reflector.Members.IsComplete)
             {
-                result = LookupMember(name, false /*skipReadOnlyCheck*/);
+                result = LookupMember(name, skipReadOnlyCheck: false);
                 result = _reflector.Members.TryAdd(name, result);
             }
             return result;
@@ -755,7 +755,7 @@ protected virtual XamlMember LookupContentProperty()
                 {
                     return null;
                 }
-                return GetPropertyOrUnknown(contentPropertyName, false /*skipReadOnlyCheck*/);
+                return GetPropertyOrUnknown(contentPropertyName, skipReadOnlyCheck: false);
             }
             if (BaseType is not null)
             {
@@ -1430,7 +1430,7 @@ private XamlMember GetPropertyOrUnknown(string propertyName, bool skipReadOnlyCh
             XamlMember result = skipReadOnlyCheck ? LookupMember(propertyName, true) : GetMember(propertyName);
             if (result is null)
             {
-                result = new XamlMember(propertyName, this /*declaringType*/, false /*isAttachable*/);
+                result = new XamlMember(propertyName, declaringType: this, isAttachable: false);
             }
             return result;
         }

Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ internal XamlType ServiceProvider_ResolveXamlType(string qName)`
`168`	`168`
`169`	`169`	`internal AmbientPropertyValue ServiceProvider_GetFirstAmbientValue(IEnumerable<XamlType> ceilingTypes, XamlMember[] properties)`
`170`	`170`	`{`
`171`		`- List<AmbientPropertyValue> valueList = FindAmbientValues(ceilingTypes, /searchLiveStackOnly/false, /types/null, properties, true);`
	`171`	`+ List<AmbientPropertyValue> valueList = FindAmbientValues(ceilingTypes, searchLiveStackOnly: false, types: null, properties, true);`
`172`	`172`	`return (valueList.Count == 0) ? null : valueList[0];`
`173`	`173`	`}`
`174`	`174`
`@@ -180,7 +180,7 @@ internal object ServiceProvider_GetFirstAmbientValue(XamlType[] types)`
`180`	`180`
`181`	`181`	`internal IEnumerable<AmbientPropertyValue> ServiceProvider_GetAllAmbientValues(IEnumerable<XamlType> ceilingTypes, XamlMember[] properties)`
`182`	`182`	`{`
`183`		`- List<AmbientPropertyValue> valueList = FindAmbientValues(ceilingTypes, /searchLiveStackOnly/false, /types/null, properties, /stopAfterFirst/ false);`
	`183`	`+ List<AmbientPropertyValue> valueList = FindAmbientValues(ceilingTypes, searchLiveStackOnly: false, types: null, properties, stopAfterFirst: false);`
`184`	`184`	`return valueList;`
`185`	`185`	`}`
`186`	`186`
Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ private XamlRuntime CreateRuntime(XamlObjectWriterSettings settings, XamlSchemaC`
`129`	`129`	`}`
`130`	`130`	`if (result is null)`
`131`	`131`	`{`
`132`		`- result = new ClrObjectRuntime(runtimeSettings, true /isWriter/);`
	`132`	`+ result = new ClrObjectRuntime(runtimeSettings, isWriter: true);`
`133`	`133`	`}`
`134`	`134`	`result.LineInfo = this;`
`135`	`135`	`return result;`
`@@ -604,7 +604,7 @@ public override void WriteStartMember(XamlMember property)`
`604`	`604`
`605`	`605`	`// Duplicate Property Setting Check.`
`606`	`606`	`//`
`607`		`- Logic_DuplicatePropertyCheck(_context, property, false /onParent/);`
	`607`	`+ Logic_DuplicatePropertyCheck(_context, property, onParent: false);`
`608`	`608`
`609`	`609`	`// If we haven't created the object yet then consider creating it now.`
`610`	`610`	`// We need an object instance to set property values on.`
`@@ -1529,7 +1529,7 @@ private void Logic_ApplyCurrentPreconstructionPropertyValues(ObjectWriterContext`
`1529`	`1529`	`}`
`1530`	`1530`	`else`
`1531`	`1531`	`{`
`1532`		`- Logic_ApplyPropertyValue(ctx, prop, value, false /onParent/);`
	`1532`	`+ Logic_ApplyPropertyValue(ctx, prop, value, onParent: false);`
`1533`	`1533`	`}`
`1534`	`1534`	`}`
`1535`	`1535`	`}`
`@@ -2009,7 +2009,7 @@ private void Logic_DoAssignmentToParentProperty(ObjectWriterContext ctx)`
`2009`	`2009`
`2010`	`2010`	`if (!ctx.CurrentIsObjectFromMember)`
`2011`	`2011`	`{`
`2012`		`- Logic_ApplyPropertyValue(ctx, parentProperty, value, true /onParent/);`
	`2012`	`+ Logic_ApplyPropertyValue(ctx, parentProperty, value, onParent: true);`
`2013`	`2013`
`2014`	`2014`	`// registered a named object`
`2015`	`2015`	`if (parentProperty == parentType.GetAliasedProperty(XamlLanguage.Name))`
Original file line number	Diff line number	Diff line change
`@@ -321,14 +321,14 @@ private void ResolvePropertyName(string longName)`
`321`	`321`
`322`	`322`	`if (propName.IsDotted)`
`323`	`323`	`{`
`324`		`- prop = _context.GetDottedProperty(tagType, tagNamespace, propName, false /tagIsRoot/);`
	`324`	`+ prop = _context.GetDottedProperty(tagType, tagNamespace, propName, tagIsRoot: false);`
`325`	`325`	`}`
`326`	`326`	`// Regular property p`
`327`	`327`	`else`
`328`	`328`	`{`
`329`	`329`	`string ns = _context.GetAttributeNamespace(propName, Namespace);`
`330`	`330`	`declaringType = _context.CurrentType;`
`331`		`- prop = _context.GetNoDotAttributeProperty(declaringType, propName, Namespace, ns, false /tagIsRoot/);`
	`331`	`+ prop = _context.GetNoDotAttributeProperty(declaringType, propName, Namespace, ns, tagIsRoot: false);`
`332`	`332`	`}`
`333`	`333`	`_tokenProperty = prop;`
`334`	`334`	`}`
Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ private XamlMember GetXamlAttributeProperty(XamlParserContext context, XamlPrope`
`152`	`152`	`if (propName.IsDotted)`
`153`	`153`	`{`
`154`	`154`	`XamlType attachedOwnerType = new XamlType(string.Empty, propName.OwnerName, null, context.SchemaContext);`
`155`		`- unknownProperty = new XamlMember(propName.Name, attachedOwnerType, true /isAttachable/);`
	`155`	`+ unknownProperty = new XamlMember(propName.Name, attachedOwnerType, isAttachable: true);`
`156`	`156`	`}`
`157`	`157`	`else`
`158`	`158`	`{`
Original file line number	Diff line number	Diff line change
`@@ -122,15 +122,15 @@ private Dictionary<Type, DelegateCreator> DelegateCreators`
`122`	`122`
`123`	`123`	`internal DynamicMethodRuntime(XamlRuntimeSettings settings, XamlSchemaContext schemaContext,`
`124`	`124`	`XamlAccessLevel accessLevel)`
`125`		`- : base(settings, true /isWriter/)`
	`125`	`+ : base(settings, isWriter: true)`
`126`	`126`	`{`
`127`	`127`	`Debug.Assert(schemaContext is not null);`
`128`	`128`	`Debug.Assert(accessLevel is not null);`
`129`	`129`	`_schemaContext = schemaContext;`
`130`	`130`	`_localAssembly = Assembly.Load(accessLevel.AssemblyAccessToAssemblyName);`
`131`	`131`	`if (accessLevel.PrivateAccessToTypeName is not null)`
`132`	`132`	`{`
`133`		`- _localType = _localAssembly.GetType(accessLevel.PrivateAccessToTypeName, true /throwOnError/);`
	`133`	`+ _localType = _localAssembly.GetType(accessLevel.PrivateAccessToTypeName, throwOnError: true);`
`134`	`134`	`}`
`135`	`135`	`}`
`136`	`136`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ class PartialTrustTolerantRuntime : XamlRuntime`
`37`	`37`
`38`	`38`	`public PartialTrustTolerantRuntime(XamlRuntimeSettings runtimeSettings, XamlAccessLevel accessLevel, XamlSchemaContext schemaContext)`
`39`	`39`	`{`
`40`		`- _transparentRuntime = new ClrObjectRuntime(runtimeSettings, true /isWriter/);`
	`40`	`+ _transparentRuntime = new ClrObjectRuntime(runtimeSettings, isWriter: true);`
`41`	`41`	`_accessLevel = accessLevel;`
`42`	`42`	`_schemaContext = schemaContext;`
`43`	`43`	`}`
Original file line number	Diff line number	Diff line change
`@@ -65,11 +65,11 @@ internal static XamlCollectionKind LookupCollectionKind(Type type, out MethodInf`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`// If the type doesn't match any of the interfaces, check for Add methods`
`68`		`- if (TryGetDictionaryAdder(type, false /mayBeIDictionary/, out addMethod))`
	`68`	`+ if (TryGetDictionaryAdder(type, mayBeIDictionary: false, out addMethod))`
`69`	`69`	`{`
`70`	`70`	`return XamlCollectionKind.Dictionary;`
`71`	`71`	`}`
`72`		`- if (TryGetCollectionAdder(type, false /mayBeICollection/, out addMethod))`
	`72`	`+ if (TryGetCollectionAdder(type, mayBeICollection: false, out addMethod))`
`73`	`73`	`{`
`74`	`74`	`return XamlCollectionKind.Collection;`
`75`	`75`	`}`
`@@ -83,14 +83,14 @@ internal static MethodInfo LookupAddMethod(Type type, XamlCollectionKind collect`
`83`	`83`	`switch (collectionKind)`
`84`	`84`	`{`
`85`	`85`	`case XamlCollectionKind.Collection:`
`86`		`- bool isCollection = TryGetCollectionAdder(type, true /mayBeICollection/, out result);`
	`86`	`+ bool isCollection = TryGetCollectionAdder(type, mayBeICollection: true, out result);`
`87`	`87`	`if (isCollection && result is null)`
`88`	`88`	`{`
`89`	`89`	`throw new XamlSchemaException(SR.Format(SR.AmbiguousCollectionItemType, type));`
`90`	`90`	`}`
`91`	`91`	`break;`
`92`	`92`	`case XamlCollectionKind.Dictionary:`
`93`		`- bool isDictionary = TryGetDictionaryAdder(type, true /mayBeIDictionary/, out result);`
	`93`	`+ bool isDictionary = TryGetDictionaryAdder(type, mayBeIDictionary: true, out result);`
`94`	`94`	`if (isDictionary && result is null)`
`95`	`95`	`{`
`96`	`96`	`throw new XamlSchemaException(SR.Format(SR.AmbiguousDictionaryItemType, type));`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ public string GetAttributeString(Type attributeType, out bool checkedInherited)`
`66`	`66`	`// Passes inherit=true for reasons explained in comment on XamlType.TryGetAttributeString`
`67`	`67`	`checkedInherited = true;`
`68`	`68`
`69`		`- object[] attributes = CustomAttributeProvider.GetCustomAttributes(attributeType, true /inherit/);`
	`69`	`+ object[] attributes = CustomAttributeProvider.GetCustomAttributes(attributeType, inherit: true);`
`70`	`70`	`if (attributes.Length == 0)`
`71`	`71`	`{`
`72`	`72`	`return null;`
Original file line number	Diff line number	Diff line change
`@@ -754,23 +754,23 @@ private List<MethodInfo> LookupStaticAdders(string name)`
`754`	`754`	`string adderName = KnownStrings.Add + name + KnownStrings.Handler;`
`755`	`755`	`MemberInfo[] adders = UnderlyingType.GetMember(adderName, MemberTypes.Method, AttachableProperties_BF);`
`756`	`756`	`List<MethodInfo> preferredAdders, otherAdders;`
`757`		`- PrioritizeAccessors(adders, true /isEvent/, false /isGetter/, out preferredAdders, out otherAdders);`
	`757`	`+ PrioritizeAccessors(adders, isEvent: true, isGetter: false, out preferredAdders, out otherAdders);`
`758`	`758`	`return preferredAdders ?? otherAdders;`
`759`	`759`	`}`
`760`	`760`
`761`	`761`	`private List<MethodInfo> LookupStaticGetters(string name)`
`762`	`762`	`{`
`763`	`763`	`MemberInfo[] getters = UnderlyingType.GetMember(KnownStrings.Get + name, MemberTypes.Method, AttachableProperties_BF);`
`764`	`764`	`List<MethodInfo> preferredGetters, otherGetters;`
`765`		`- PrioritizeAccessors(getters, false /isEvent/, true /isGetter/, out preferredGetters, out otherGetters);`
	`765`	`+ PrioritizeAccessors(getters, isEvent: false, isGetter: true, out preferredGetters, out otherGetters);`
`766`	`766`	`return preferredGetters ?? otherGetters;`
`767`	`767`	`}`
`768`	`768`
`769`	`769`	`private List<MethodInfo> LookupStaticSetters(string name)`
`770`	`770`	`{`
`771`	`771`	`MemberInfo[] setters = UnderlyingType.GetMember(KnownStrings.Set + name, MemberTypes.Method, AttachableProperties_BF);`
`772`	`772`	`List<MethodInfo> preferredSetters, otherSetters;`
`773`		`- PrioritizeAccessors(setters, false /isEvent/, false /isGetter/, out preferredSetters, out otherSetters);`
	`773`	`+ PrioritizeAccessors(setters, isEvent: false, isGetter: false, out preferredSetters, out otherSetters);`
`774`	`774`	`return preferredSetters ?? otherSetters;`
`775`	`775`	`}`
`776`	`776`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ public override XamlProperty GetDirectiveProperty(string name)`
`75`	`75`	`if (directive == null)`
`76`	`76`	`{`
`77`	`77`	`directive = new UnknownProperty(name,`
`78`		`- null, /declaringType - xml directives don't have one. /`
	`78`	`+ declaringType: null, /* xml directives don't have a declaring type. */`
`79`	`79`	`XmlDirectives.Uri);`
`80`	`80`	`}`
`81`	`81`	`return directive;`