Fixing/clarifying XML comments for ScreenCaptureMode and VB's ColorMode. #14074
+10
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14074 +/- ##
===================================================
- Coverage 77.16719% 77.15758% -0.00962%
===================================================
Files 3279 3279
Lines 645317 645317
Branches 47718 47718
===================================================
- Hits 497973 497911 -62
- Misses 143657 143720 +63
+ Partials 3687 3686 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Shyam-Gupta
approved these changes
Nov 24, 2025
Comment on lines
+7
to
+8
| /// Enumeration defining the behavior when a form is attempted to be captured in a screen capture (clipboard, image file), | ||
| /// in a screen sharing video conference scenario, a video recording or the alike. |
Member
There was a problem hiding this comment.
It appears a bit convoluted. Consider:
An enumeration specifying the behavior of a form when an attempt is made to capture it via screenshot, clipboard, image export, screen-sharing during a video conference, video recording, or similar methods.
adegeo
reviewed
Nov 25, 2025
| /// <summary> | ||
| /// The form or control can be captured normally in screenshots. Default. | ||
| /// The form can be captured normally in screen captures. | ||
| /// Default setting. |
There was a problem hiding this comment.
Default shouldn't be specified here, it should be specified on the property using this enum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of issues in XML comments for the ScreenCaptionMode and clarifies the usage of the ColorMode property in VB's
ApplyApplicationDefaultEventArg.Microsoft Reviewers: Open in CodeFlow