Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to main branch to address #12042 #12674

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pcblues
Copy link

@pcblues pcblues commented Dec 23, 2024

Fixes #12042 - TreeNode and ListItem not displaying in dark mode during editing, even though application is set to be in dark mode.

Proposed changes

If the application is in dark mode, capture the parent's windows message to identify the start of editing, and change the colour of the brush to match the parent's window color.

Customer Impact

Correction of incorrect color selection.

Regression?

  • Yes / No

Risk

I tried to limit the impact of the change to only occurring when the application is in dark mode. I'm not sure of the impact, if any, on custom ListView subitems, or custom-drawn TreeNodes.

Screenshots

Before

364259285-197881bf-5284-493c-b665-ee5d47c9541c

After

image

Test methodology

I used the test application provided to highlight the bug in the ticket to test the new behaviour.

Accessibility testing

Test environment(s)

Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 21.42857% with 22 lines in your changes missing coverage. Please review.

Project coverage is 76.02900%. Comparing base (2321dc8) to head (739a255).
Report is 4 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12674         +/-   ##
===================================================
- Coverage   76.03358%   76.02900%   -0.00459%     
===================================================
  Files           3180        3181          +1     
  Lines         639670      639698         +28     
  Branches       47215       47217          +2     
===================================================
- Hits          486364      486356          -8     
- Misses        149791      149822         +31     
- Partials        3515        3520          +5     
Flag Coverage Δ
Debug 76.02900% <21.42857%> (-0.00459%) ⬇️
integration 18.16885% <0.00000%> (-0.00568%) ⬇️
production 49.81813% <21.42857%> (-0.00878%) ⬇️
test 97.02915% <ø> (+0.00083%) ⬆️
unit 47.04530% <21.42857%> (+0.02242%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@pcblues
Copy link
Author

pcblues commented Dec 23, 2024

Hi there. I'm not sure what to do with the codecov report. For perspective, I have been a developer for 20 odd years, but haven't done changes through github for MS before. Cheers.

@dotnet-policy-service dotnet-policy-service bot added the draft draft PR label Dec 23, 2024
@Tanya-Solyanik Tanya-Solyanik added the area-DarkMode Issues relating to Dark Mode feature label Dec 23, 2024
@pcblues
Copy link
Author

pcblues commented Dec 24, 2024

@pcblues please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

@pcblues pcblues marked this pull request as ready for review December 24, 2024 01:24
@pcblues pcblues requested a review from a team as a code owner December 24, 2024 01:24
@pcblues
Copy link
Author

pcblues commented Dec 24, 2024

This is my first PR for MS. I didn't really understand what was happening with the accessibility testing software.

@dotnet-policy-service dotnet-policy-service bot removed the draft draft PR label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-DarkMode Issues relating to Dark Mode feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dark Mode] The nodes of TreeView not in dark mode when editing it
2 participants